[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#851884: marked as done (RFS: fdkaac/0.6.3-1)



Your message dated Wed, 25 Jan 2017 07:08:10 -0700
with message-id <20170125140810.laynt3yh5stlm74p@iris.silentflame.com>
and subject line Re: Bug#851884: RFS: fdkaac/0.6.3-1
has caused the Debian Bug report #851884,
regarding RFS: fdkaac/0.6.3-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
851884: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851884
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "fdkaac"

 * Package name    : fdkaac
   Version         : 0.6.3-1
   Upstream Author : nu774 <honeycomb77@gmail.com>
 * URL             : https://github.com/nu774/fdkaac
 * License         : Zlib
   Section         : sound

It builds those binary packages:

  fdkaac     - command line encoder frontend for libfdk-aac

To access further information about this package, please visit the following URL:

  https://mentors.debian.net/package/fdkaac


Alternatively, one can download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/contrib/f/fdkaac/fdkaac_0.6.3-1.dsc

More information about hello can be obtained from https://www.example.com.

Changes since the last upload:

  * New upstream version
  * Bump Standards-Version to 3.9.8
  * Mark as XS-Autobuild: yes
  * Use hardening compilation options

Regards,
-- 
Marius Gavrilescu

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Dear Marius,

Signed & uploaded!

On Tue, Jan 24, 2017 at 04:27:37PM +0000, Marius Gavrilescu wrote:
> Sean Whitton <spwhitton@spwhitton.name> writes:
> 
> > I'm sorry for not conducting a more through review before, but I've
> > found the following remaining issues.  Hopefully you can resolve them
> > quickly and I can upload for you.
> >
> > 1. The package does not build against sid because the build-dep
> >    libfdk-aac-dev is not installable right now.  Any ideas?
> 
> libfdk-aac-dev:amd64 (0.1.4-2) installs just fine on my newly created
> sid virtual machine.
> 
> I have also successfully built and installed the package on said sid
> machine.

Sorry, this was my fault for not including non-free.

> Could it be a problem that the packages I upload to mentors are built
> on wheezy? If so, I can just build and upload from the sid machine.

No, since mentors strips binary packages and offers only the .dsc for
download.

> > Optional suggestion:
> >
> > 3. Your git repository does not exactly match the source package you
> >    have provided.  I've attached the diff.  It's good practice to have
> >    your git HEAD exactly match what you want to be uploaded.  But if
> >    this is difficult to fix, just ignore it and I will work from your
> >    source package.
> 
> From the diff I see the issue is different line terminators. But both my
> git repository and the source package have CRLFs (according to file(1)).
> 
> I am using git-buildpackage with pristine-tar to build this package.
> I've checked and the .orig.tar.gz I was using is identical to the one
> created by pristine-tar, so I do not know where the LFs are coming from.
> Could you suggest a way to debug this?

I have not had to deal with CRLFs in Debian packages before.  I think
that dpkg-source is doing some implicit conversion of CRLFs to LFs,
probably when it extracts the source package (`dpkg-source -x`).  Then
the extracted source package disagrees with git.

Since I've not had to deal with this in my own packages, I do not have a
solution to offer you.  I'd like to suggest that you write to
<debian-mentors@lists.debian.org> asking for advice from those who have
had to deal with this.  I'm looking forward to reading their replies
myself!

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply to: