Sean Whitton <spwhitton@spwhitton.name> writes: > I'm sorry for not conducting a more through review before, but I've > found the following remaining issues. Hopefully you can resolve them > quickly and I can upload for you. > > 1. The package does not build against sid because the build-dep > libfdk-aac-dev is not installable right now. Any ideas? libfdk-aac-dev:amd64 (0.1.4-2) installs just fine on my newly created sid virtual machine. I have also successfully built and installed the package on said sid machine. Could it be a problem that the packages I upload to mentors are built on wheezy? If so, I can just build and upload from the sid machine. > 2. The change to Vcs-Git is not mentioned in the changelog. Fixed and reuploaded to mentors. > Optional suggestion: > > 3. Your git repository does not exactly match the source package you > have provided. I've attached the diff. It's good practice to have > your git HEAD exactly match what you want to be uploaded. But if > this is difficult to fix, just ignore it and I will work from your > source package. From the diff I see the issue is different line terminators. But both my git repository and the source package have CRLFs (according to file(1)). I am using git-buildpackage with pristine-tar to build this package. I've checked and the .orig.tar.gz I was using is identical to the one created by pristine-tar, so I do not know where the LFs are coming from. Could you suggest a way to debug this? Thanks, -- Marius Gavrilescu
Attachment:
signature.asc
Description: PGP signature