Bug#838801: RFS: zxcvbn-c/0.20150103-1 [ITP]

[Gianfranco Costamagna <locutusofborg@debian.org>]

control: owner -1 !
control: tags -1 moreinfo

Hi Sean,


>    libzxcvbn-dev - password strength estimation library - development files

>    libzxcvbn0 - password strength estimation library



I'm a little bit worried about the makefile :(

CFLAGS ?= -O2 -Wall -Wextra -Wdeclaration-after-statement
CPPFLAGS ?= -O2 -Wall -Wextra


this is a no-op I guess, maybe a "+=" might be better
gcc $(CFLAGS) $(LDFLAGS) -fPIC -shared -Wl,-soname,$(SONAME) -o $@ $^ -lm

this is wrong in many places, e.g.:

"gcc" might be a $(CC)
with 

$(CC) ?= gcc
as example (I don't see a good reason for forcing a gcc when people might want
to try to build it with clang as example)

LDFLAGS should be at the bottom of the ine, just before -lm, to avoid stripping
with wl-asneeded flag (and build failures)


blhc:

CXXFLAGS missing (-g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security): g++ -std=c++11 -Wdate-time -D_FORTIFY_SOURCE=2 -I. -o dictgen dict-generate.cpp
LDFLAGS missing (-fPIE -pie -Wl,-z,relro -Wl,-z,now): g++ -std=c++11 -Wdate-time -D_FORTIFY_SOURCE=2 -I. -o dictgen dict-generate.cpp
CPPFLAGS missing (-D_FORTIFY_SOURCE=2): gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fPIE -fstack-protector-strong -Wformat -Werror=format-security -I. -DUSE_DICT_FILE -c -o zxcvbn-file.o zxcvbn.c

deb files:
-rw-r--r-- root/root    568880 2016-09-25 01:14 ./usr/lib/x86_64-linux-gnu/libzxcvbn.a

static library? ok if you think it is useful


other stuff is good :)

thanks!

G.