Re: Bug#838941: RFS: duperemove/0.11~beta3-3 ITP

[Peter Zahradnik <petzah@znik.sk>]

On 2016-09-28 14:07, Adam Borowski wrote:
> On Wed, Sep 28, 2016 at 11:24:20AM +0200, Dariusz Dwornikowski wrote:
> > On 26 September 2016 at 23:12,  <peter.zahradnik@znik.sk> wrote:
> > >  * Package name    : duperemove
> > >    Version         : 0.11~beta3-3
> >
> > "When given the -d option, duperemove will submit those extents for
> > deduplication using the btrfs-extent-same ioctl."
>
> It's a vital piece of information, as without this option duperemove 
> does
> nothing but waste CPU and I/O.  An user would be able to use it 
> intuitively
> otherwise.
>
> I have no idea why dry run is the default (probably from early debug
> times?), but compared to most similar programs, the output is pretty
> useless for purposes other than deduplicating, as duperemove does some
> heurestics and thus its results are incomplete.
>
> Thus, this option is needed to get started.  On the other hand, perhaps 
> it
> could be better to make a patch to switch the logic and have a 
> --dry-run
> option instead?

Thank you both for reviews, much appreciated.

@Adam
Make sense, I'll try to create patch for --dry-run and push it upstream

@Dariusz
I've removed -d from d/control for now and fixed d/changelog
Pristine-tar branch has been pushed to github
Upstream author released 0.11-beta4 so I could drop the patch with wrong 
utf8
coding altogether

new version has been uploaded to mentors
https://mentors.debian.net/debian/pool/main/d/duperemove/duperemove_0.11~beta4-1.dsc

thanks
Peter