[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#835253: RFS: steghide/0.5.1-11 [QA]



Hello, Gianfranco.

Thanks a lot for taking some time to verify this.

I tried to follow your recommendations:


On 09/12/2016 05:05 PM, Gianfranco Costamagna wrote:
> BTW, what about having the documentation in a separate -doc package?
> (and in the doc standard location)

I tried to to that. But then I had to add doxygen as a build-dep.

> 1) std-version is now 3.9.8

Corrected that.

>
> 2) 
> -rw-r--r-- root/root      6816 2016-08-22 23:03 ./usr/share/doc/steghide/COPYING.gz
>
>
> now this file is installed (and probably useless)
> quoting changelog:
>
> +  * Refixed so that INSTALL and COPYING information is not in the
> +    deb archive.
>
>
>
> quoting old rules:
>
> +       $(MAKE) install prefix=`pwd`/debian/steghide/usr
> +       rm -rf `pwd`/debian/steghide/usr/doc
> +       rm -f `pwd`/debian/steghide/usr/share/doc/steghide/INSTALL
> +       rm -f `pwd`/debian/steghide/usr/share/doc/steghide/INSTALL.gz
> +       rm -f `pwd`/debian/steghide/usr/share/doc/steghide/COPYING
>
>
> so, I would try to remove it again

Well, I just used the same commands, just not the make install part.

>
> 3) this RFS has been picked up by Breno, so he should have the final words about the
> package :)
> (I hope he don't mind my review, and hope he won't ask you to change something back)

I talked to Breno last week, he said he might not have time to do this
and it would
be fine if you sponsored this one.

If you could take a look I would appreciate.

It can be found at the same place:

  dget -x
https://mentors.debian.net/debian/pool/main/s/steghide/steghide_0.5.1-11.dsc

Thanks!

-- 
Fernando Seiti Furusato
IBM Linux Technology Center


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: