Bug#835253: RFS: steghide/0.5.1-11 [QA]
Hi, while waiting for Bruno's review, I'm adding another little (unasked)
one.
debdiff steghide_0.5.1-10_amd64.deb steghide_0.5.1-11_amd64.deb
you are installing too many manpages
-rw-r--r-- root/root /usr/share/man/man3/BmpFile.3.gz
-rw-r--r-- root/root /usr/share/man/man3/BmpFile.h.3.gz
-rw-r--r-- root/root /usr/share/man/cc/man3/error.3.gz
-rw-r--r-- root/root /usr/share/man/cc/man3/msg.3.gz
and so on for ~300 lines
something broke the po files
before:
installing es.gmo as /build/steghide-0.5.1/debian/steghide/usr/share/locale/es/LC_MESSAGES/steghide.mo
now:
/usr/bin/install: cannot create regular file '/build/steghide-0.5.1/debian/steghide/usr/share/locale/es/LC_MESSAGES/steghide.mo': No such file or directory
and debdiff shows:
Files in first .deb but not in second
-------------------------------------
-rw-r--r-- root/root /usr/share/locale/de/LC_MESSAGES/steghide.mo
-rw-r--r-- root/root /usr/share/locale/es/LC_MESSAGES/steghide.mo
-rw-r--r-- root/root /usr/share/locale/fr/LC_MESSAGES/steghide.mo
-rw-r--r-- root/root /usr/share/locale/ro/LC_MESSAGES/steghide.mo
this seems because of a missing patch on po/Makefile.in.in directory
+- $(mkinstalldirs) $(DESTDIR)$$dir; \
you need to patch it to create the directory.
(this is a bad effect of the migration to autoreconf.
Patching autogenerated files is bad, because autoreconf overrides the changes).
Please try to patch the source Makefile.in.in and let autoreconf to the remaining stuff :D
debdiff between sources dsc files shows changes not converted in patch
e.g.
po/de.po
doxygen and spec files
(and probably more)
override_dh_auto_clean:
if [ -e Makefile ]; then $(MAKE) distclean; fi
^^ the above should be useless, and partially wrong
(in fact it seems to be not working to me)
if [ -f Makefile]; then dh_auto_clean; fi
might be better, even if I would just remove that line
hope this helps,
G.
Reply to: