[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: setop/0.1-1 [ITP]



Hello Gianfranco!

First of all thank you very much for taking care of me. I had already given up and left setop behind me.


Am 04.04.2016 um 15:39 schrieb Gianfranco Costamagna:
nobody usually sponsors stuff without an RFS bug.

And sending a mail with RFS in the subject isn't a bug :)

Is it this one?
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813485>
I exactly followed all instructions from <http://mentors.debian.net/sponsor/rfs-howto> and/or <https://wiki.debian.org/Mentors/BTS> and still don’t know, where my mistake was.

In summary – you probably hear that often – it is very difficult for a newbie to make everything right. Moreover, I think there are mistakes in some guides that lead to errors.


"CXXFLAGS = -std=c++11 -O3"

I think you shouldn't force -O3 and for sure you shouldn't override external flags.

Omitting -O3 yields in making a debug version (equal to -O0) on my system. By default, the make file shall produce a release build, and by testing I found out that O2 and O3 are best compared to the alternatives (e. g. Os).
Ok?


also for BIN *FLAGS

I don’t understand what you mean by that.


so please use LIBS instead.

control: std-version is 3.9.7

Done.


some b-d might be useless
"libboost-all-dev" is it useful?

You’re correct, I meant libboost-dev.


insecure VCS fields

$ codespell --quiet-level=3
./TODO:13: comparision  ==> comparison

No further spelling errors found.


copyright:
"the work is not subject to copyright in any jurisdiction."

this license seems not possible.
You cannot force jurisdiction to not copyright your stuff.

Difficult for me to understand the difference between unlicense and public-domain. I changed the text as you suggested, but kept the public-domain keyword:
<https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification>

If that is not ok, tell me. PDM seems to be another possibility: http://creativecommons.org/publicdomain/mark/1.0/


please add a watch file.

You should check it. It’s taken from <https://wiki.debian.org/debian /watch#GitHub>, but mentors.debian.net says it doesn’t work.


Reminder: setop is available at http://mentors.debian.net/package/setop or via
dget -x http://mentors.debian.net/debian/pool/main/s/setop/setop_0.1-1.dsc


Many thanks,
Frank


Reply to: