Bug#820165: RFS: libretro-genesisplusgx/1.7.4+git20160330 [ITP]

[Sérgio Benjamim <sergio_br2@yahoo.com.br>]

Hey!

> Hi Sergio, the copyright needs a complete rework.
> BSD-2 BSD-3 BSD zlib/libpng GPL-2 are only some of the missing licenses.
>
> please take care of them.

There are a bunch of false positive with licensecheck, many BSD which
is actually non-commercial (old mame license). I think I fixed the others
BSD-3 and zlib.


> sdl looks like an embedded library to me

I think that sdl folder is only the sdl port, it's not SDL code itself.


> also tremor

From the copyright:

Comment: the package uses libvorbis-dev instead, libvorbisidec-dev is
 not compatible (there's only noisy, upstream use a different version or
 they changed the code) so use tremor from this folder on platforms that
 lacks floating point.

Tremor is there just for non-floating point platforms. It'll link against
libvorbis-dev on amd64 and armhf for example.
You'll need libvorbis or tremor to play Sega CD games with OGG files.


> copyright holders are missing
>
> ./sdl/fileio.c: *  Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003  Charles Mac Donald
> ./sdl/fileio.h: *  Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003  Charles Mac Donald

It's "MacDonald" actually, this space is a typo. And he's in Files: *


> EkeEke is owner of many other copyrights in the source code

Eke-Eke is also in Files: *


> can't you use libretro from new queue?

You mean use the latest git commit? Done.


> std-version is 3.9.8 now

This thing changes really fast heh.


Thanks for the review!
sergio-br2