control: owner -1 ! control: tags -1 moreinfo Hi, > https://mentors.debian.net/package/libretro-desmume licenses are missing e.g. some Expat desmume/src/emufile.* desmume/src/arm_jit.h: GPL (v3 or later) desmume/src/instruction_attributes.h: GPL (v3 or later) desmume/src/libretro/arm_arm/arm_jit.cpp: GPL (v3 or later) and probably many more debian packaging should be GPL-2+ and not GPL-3+, otherwise you might not be able to forward patches back in GPL-2+ mode. debian/install with an sh script inside is something that worries me a little bit (even if possible) can't you please override dh_install in rules? I don't like hidden scripts too much (instead I would prefer dh-exec) ./desmume/src/utils/emufat.h://Copyright (C) 1991 Linus Torvalds <torvalds@klaava.helsinki.fi> ./desmume/src/utils/emufat.h://Copyright (C) 1992-1993 Remy Card <card@masi.ibp.fr> ./desmume/src/utils/emufat.h://Copyright (C) 1993-1994 David Hudson <dave@humbug.demon.co.uk> ./desmume/src/utils/emufat.h://Copyright (C) 1998 H. Peter Anvin <hpa@zytor.com> ./desmume/src/utils/emufat.h://Copyright (C) 1998-2005 Roman Hodek <Roman.Hodek@informatik.uni-erlangen.de> ./desmume/src/utils/datetime.h:// Copyright (C) 2004-2006 Novell, Inc (http://www.novell.com) missing and probably many more check-all-the-things review: $ codespell --quiet-level=3 $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.' grep -riE 'fixme|todo|hack|xxx' . also flawfinder shows a lot of stuff. I didn't check lintian and to build, I'll do as soon as the above is fixed. G.
Attachment:
signature.asc
Description: OpenPGP digital signature