Bug#818227: RFS: kawa/2.1-1 [ITP] -- Scheme implementation for the JVM
control: owner -1 !
control: tags -1 moreinfo
Hi, lets review:
- maybe you should put this package under pkg-java umbrella
- please ask upstream to relicense the documentation
- Tag: devel::compiler, devel::interpreter, devel::lang:scheme, (missing space at
the begin)
Build-Depends: debhelper (>=9), autotools-dev, openjdk-7-jdk | openjdk-8-jdk, openjdk-7-jre | openjdk-8-jre, libjline2-java
please run autoreconf and be compatible with openjdk-9
check-all-the-things review:
codespell --quiet-level=3
cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'
grep -Er '/(home|srv|opt)(\W|$)' .
flawfinder -Q -c .
licensecheck --check=. --recursive --copyright . | grep -F 'with incorrect FSF address'
suspicious-source
grep -r '/tmp/' .
grep -riE 'fixme|todo|hack|xxx' .
Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
find -type f -iname '*.xml' -exec xmllint --noout --nonet {} +
(lots)
grep copyright . -Ri |grep -v Bothner
lots of missing people
lots of missing licenses, e.g.
bin/kawa.c
gnu/jemacs/lisp/*.el
and probably more
(do you have any embedded lisp libraries?)
cheers,
Gianfranco
Reply to: