Bug#847308: Bug#847076: ITP: gnome-shell-extension-shortcuts -- Creates a shortcuts help pop-up in GNOME Shell
Am Montag, den 12.12.2016, 09:22 +0200 schrieb Kyle Robbertze:
> On 08/12/2016 21:44, Tobias Frost wrote:
> > Control: tags -1 moreinfo
> >
> > Hi Kyle,
> >
> > (sorry, I missed a bit the last review)
> >
> > d/changelog:
> > - do not bump version until the first upload is done.
> > in other words, it should just read, no other entries
>
> Fixed
> > - there is an trailing space in d/control line 15
>
> Fixed
> > - d/dirs is not needed.
>
> Removed
> >
> > - d/rules: (this is bikeshedding, you do not need to follow) I
> > prefer
> > to clean via (the file) d/clean not via an override in d/rules.
>
> Changed (I see why you prefer it. Much neater)
As with the other RFS:
just list the files in d/clean, no rm -r in front of it.
> >
> > - src/convenience.js is originally not copyrighted by you, but
> > by Giovanni Campagna <scampa.giovanni@gmail.com> and also under
> > BSD-3-clause. Please approbiatly attribute copyrights
Reply to: