On 08/12/2016 21:44, Tobias Frost wrote: > Control: tags -1 moreinfo > > Hi Kyle, > > (sorry, I missed a bit the last review) > > d/changelog: > - do not bump version until the first upload is done. > in other words, it should just read, no other entries Fixed > - there is an trailing space in d/control line 15 Fixed > - d/dirs is not needed. Removed > > - d/rules: (this is bikeshedding, you do not need to follow) I prefer > to clean via (the file) d/clean not via an override in d/rules. Changed (I see why you prefer it. Much neater) > > - src/convenience.js is originally not copyrighted by you, but > by Giovanni Campagna <scampa.giovanni@gmail.com> and also under > BSD-3-clause. Please approbiatly attribute copyrights. > (This is a show stopper) Corrected > > - in the schema description is a typo: pannel. Fixed Cheers Kyle
Attachment:
signature.asc
Description: OpenPGP digital signature