On Sat, Aug 27, 2016 at 10:48:24AM -0700, Sean Whitton wrote: > control: tag -1 +moreinfo > > Hello Peter, > > Here's a few comments and questions on your package (hopefully get the > ball rolling on sponsorship). Oof, and here I was thinking I'd answered those... two months ago? Sorry :( > 1. This package has a perl and a C version of the program, and you > install the C one. Have you considered installing both and using the > alternatives system to permit the user to choose? I don't think that there would be any real purpose to that; if there is a compiled C version available, I don't see why anyone would want/need the other one. > 2. Your autopkgtest test suite appears to test the perl version? Not > sure -- would be best to add comments to the debian/test/control file. Not really; as Jakub Wilk pointed out, the autopkgtest suite uses the upstream source's test suite for testing whatever is installed as /usr/bin/install-mimic. The fact that the test suite itself uses Perl's Test Anything Protocol and prove(1) as the TAP handler is kind of besides the point. > 3. If users need to overwrite files installed by Debian packages, they > should use dpkg-divert and/or dpkg-statoverride. Perhaps it should be > stated clearly in the package description that install-mimic should be > used in combination with those tools. Hmm, actually the whole point of install-mimic is to avoid having to even know what dpkg-statoverride is :) Okay, fine, the whole point of install-mimic is to avoid hanving to know what install(1)'s arguments are and what stat(1)/stat(2) does, but you get the idea :) Nah, you're right, I might add a documentation section about various tools in various OS/distributions. However, the main use that I have for install-mimic is either for configuration files or for files installed by third-party packages... and, yeah, you're right that the examples given in the manual page do not really reflect that. I'll work on it in a future release. Thanks for trying to get the ball rolling! :) G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org pp@storpool.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
Attachment:
signature.asc
Description: PGP signature