[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

Hi Thomas,

(package removed from deferred queue)

>I have uploaded a new version to mentors with the two changes you 

>mentioned in your mails today:

>- Using dh_auto_configure instead of calling ./configure directly.

mm nack :)
dh_auto_configure already injects some flags such as libdir and multiarch stuff
it would be nice to remove them

dh_auto_configure -- --host=x86_64-linux-gnu --build=x86_64-linux-gnu --prefix=/usr --libdir=\${prefix}/lib/x86_64-linux-gnu --htmldir=\${prefix}/share/doc/libcgicc-doc/html --disable-demos
./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --host=x86_64-linux-gnu --build=x86_64-linux-gnu --prefix=/usr --libdir=\${prefix}/lib/x86_64-linux-gnu --htmldir=\${prefix}/share/doc/libcgicc-doc/html --disable-demos

I think some duplication can be avoided :)

>- Removed the Replaces and Conflicts directive for the binary package.
>Use this package if you deem those changes worth the hassle of 
>re-uploading the package to deferred/15. If not, then I'm happy to keep 
>the changes for the next time I need to update the cgicc package.

this change is nice

Also, please take the opportunity to fix the changelog as josch
pointed out :)

thanks a lot!


Reply to: