Bug#838679: [Debian-science-sagemath] Fwd: Bug#838679: RFS: cysignals/1.1.1+ds-1 [ITP] -- interrupt and signal handling for Cython
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi Ximin, thanks again for the review and the suggestions.
On 28/09/16 19:21, Ximin Luo wrote:
> Ximin Luo:
>> Hey, nice work. I'm taking a look now.
>>
>
> Hey, it looks good! I couldn't spot any problems.
>
> Just the following minor things:
>
> (1)
>
> d/rules: override_dh_install-arch: true
>
> Could you add a comment explaining this? I didn't look in too much
> detail but I couldn't figure out the reason for this. I did run
> dpkg-buildpackage -A and -B checked they still work, so that's good.
> It would be good to add a comment, so future readers don't get
> confused.
I added a short comment: in fact dh_install-arch is bypassed by dh_python
>
> (2)
>
> Instead of maintaining two separate git branches, I suggest using
> build profiles:
>
> https://wiki.debian.org/BuildProfileSpec
This is definitely a good idea.
>
> I've pushed some commits to the git repo that makes this work
> already, see if you like them, or revert if you don't :p
>
> The default build will leave out the -pari stuff. To enable the pari
> stuff, you can either :
>
> a. use `(dpkg-buildpackage|gbp buildpackage) -Ppkg.cysignals.pari`
> or b. set DEB_BUILD_PROFILES=pkg.cysignals.pari for lower-level tools
> like `debian/rules`
>
> I had to use a slight hack in debian/tests/control but I thought it
> was still worth it, to avoid switching between branches all the
> time.
>
> If you like this, please also edit debian/README.source to describe
> this new workflow.
Done. I have also deleted the experimental branches.
>
> (3)
>
> You tagged debian/1.1.1+ds-1 already in the git repo. I suggest not
> doing this yet, and delete the current tag - we have some newer
> unreleased commits anyway.
I deleted the last tag but I added a new one.
>
> My preferred workflow is to keep UNRELEASED in d/changelog, then when
> everything is ready I git push, then `dch -r`, commit, build, dput
> and wait for the ACCEPTED email from ftp-masters. Only after I get
> email, do I then run `gbp buildpackage --git-tag-only` and then push
> this last commit plus the tag that was just created.
>
> Sometimes (like now) there's no point using UNRELEASED if d/changelog
> already says something else, but the rest of the above still works.
For now I am looking for sponsorship, signed tagging the pertinent commit
makes thing clear.
Thanks,
Jerome
>
> X
>
- --
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calculus@rezozer.net
AE28 AE15 710D FF1D 87E5 A762 3F92 19A6 7F36 C68B
-----BEGIN PGP SIGNATURE-----
iQQcBAEBCgAGBQJX8am2AAoJED+SGaZ/NsaLbKwgAIcMNW5N4S/csnqTFFcSvYiT
lxknqDw/tMH01TlPQiXC6qOOZLNP825bty6TpTMoxZNBNcR9uEegdvpl4Qp3lI0e
M8wymoMJf58dkfJTgoSruAUIyYrW7mYzS/xHU1zGB2cn9UTsqmiXPoK25dltpo5y
gjL30DIMM5SS57ov8m2roj7sfeYYYDZdlCRJ4vlh2UzQexqWaeP9vwFFyxpT728S
gy4lYhWx9qXvJLRT1Jy+OAjS7b4gd2B28YrA84ld7MWxz0lAhgwuq/hamo+Oh6jQ
cMXqzkRRv3vpw6EQ5VvVvaXD+C5+Iq/ssEMgQ6Ez+KXVZ1TY4g2xTxOWyM9npAEC
wGkSL1ZD1sM/Mnr0EAkbL2MUngbU027yNH+xtm/ksyL1t/UPf/bWEpgSuYbzqr9w
NhKxL/bQFeNOofsWaISY1nz55M6AlkmTdYNwe5x4KTXNnO0JiJ04bsOO6+ExfZkB
gzxNAhhq4YvEuQSpmIBTQLU/zpvuIV9uMvM7WSgXMYUndGyW0joPOs4ZBfDAG1cR
XOtadMIGZUBsiNNfa6o+Jqkkk0nXEV1EhyojrbmwEU9elmW3j8fToAktqG7+e1pn
g9J2lNni4QnRBsehHhXD19PNnsM3MBGA6lTBXUpnIBX7wz3Kczta2K+grdAPUeGB
iPuHJNVgd6Xh6nyBGyUVNuZQSKfSGizcE5bFWfL5uUDv9gQ0QsMUZstNEgamJoWV
3LF4j8ZlK2v3vSx09V3rQG1Laps47l0L6iuLtA5p+T45EPida2K7rQodPUGadlQq
3yxo68IcHXekbwwlhQhL/m0C3+VRZ+db0vx2HPcui5EgB0PMZjiawfYfQpDDbaE2
TX6n/GfsoWkzLTOVibDMLg8UnhoGcuzf6hHgndQCfFKbQ0NwKFtZI5I51ycNHdBd
4WJvDwy4Vj12/04zq2KfUFUYfOUy81bLf9hrxHVnU5gPORzG9hEsJKaQuc3tp93z
rCXDsRyJhQEM0q2MIpW7p1gwMw+keP78Kv76AKMy3GmXQBoLytYqHDrxD8CxVzgM
LZGoDnG4AZbczKO0edvNWD+JHjjFMGd4iKbbeX8tH2JJHJF5c/kLnmRvTlfZXXbk
FKkpvVCaV3doy+YWqT+KqwgNyg0jzc+y/dG5DSuu5zCtvRyW9/xyYPe4lI/YK+Kq
kyfiB+f0XhOIqU0+Jr8RMiFBmtPPoH3OEW7dhkCWmbKX+w8L45HzqLWZTMO7tqnK
U8T3SnpT+rXy+IAYbjQtDIHtS9PHE77yAV481J7ZaHYTD0E0Bqc4rpW+Oc8/07I1
sjHT3B2qzRky8ibzjtCMRPpljpGsf/9EuDT99h4z4XzztPfrIn4nBoYrLCIs0As=
=j3xO
-----END PGP SIGNATURE-----
Reply to: