Bug#825236: RFS: openfst/1.5.3-1 -- weighted finite-state transducers library

[Jakub Wilk <jwilk@debian.org>]

* Giulio Paci <giuliopaci@gmail.com>, 2016-05-25, 19:10:
> > > https://anonscm.debian.org/git/collab-maint/openfst.git
[...]
> I added some code to restrict the build to mips, mipsel and hurd-i386.

Just like the last time[1], -O0 wasn't enough to get the tests built on 
mips:
| libtool: link: g++ -g -O0 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/algo_test_log algo_test_log-algo_test.o  ../lib/.libs/libfst.so -lm -ldl
| algo_test_log-algo_test.o: In function `fst::LookAheadCompose(fst::Fst<fst::ArcTpl<fst::TropicalWeightTpl<float> > > const&, fst::Fst<fst::ArcTpl<fst::TropicalWeightTpl<float> > > const&, fst::MutableFst<fst::ArcTpl<fst::TropicalWeightTpl<float> > >*)':
| /home/jwilk/openfst-1.5.3+r2/src/test/./algo_test.h:54:(.text+0x304): relocation truncated to fit: R_MIPS_GOT16 against `__stack_chk_guard@@GLIBC_2.4'
| /home/jwilk/openfst-1.5.3+r2/src/test/./algo_test.h:67:(.text+0x4e8): relocation truncated to fit: R_MIPS_GOT16 against `__stack_chk_guard@@GLIBC_2.4'
| /home/jwilk/openfst-1.5.3+r2/src/test/./algo_test.h:55:(.text+0x588): relocation truncated to fit: R_MIPS_CALL16 against `_Unwind_Resume@@GCC_3.0'
| /home/jwilk/openfst-1.5.3+r2/src/test/./algo_test.h:67:(.text+0x598): relocation truncated to fit: R_MIPS_CALL16 against `__stack_chk_fail@@GLIBC_2.4'
| algo_test_log-algo_test.o: In function `main':
| /home/jwilk/openfst-1.5.3+r2/src/test/algo_test.cc:41:(.text+0x5f4): relocation truncated to fit: R_MIPS_GOT16 against `__stack_chk_guard@@GLIBC_2.4'
| /home/jwilk/openfst-1.5.3+r2/src/test/algo_test.cc:42:(.text+0x600): relocation truncated to fit: R_MIPS_GOT16 against `FLAGS_fst_verify_properties'
| /home/jwilk/openfst-1.5.3+r2/src/test/algo_test.cc:43:(.text+0x60c): relocation truncated to fit: R_MIPS_GOT16 against `FailedNewHandler()'
| /home/jwilk/openfst-1.5.3+r2/src/test/algo_test.cc:43:(.text+0x610): relocation truncated to fit: R_MIPS_CALL16 against `std::set_new_handler(void (*)())@@GLIBCXX_3.4'
| /home/jwilk/openfst-1.5.3+r2/src/test/algo_test.cc:44:(.text+0x64c): relocation truncated to fit: R_MIPS_CALL16 against `SetFlags(char const*, int*, char***, bool, char const*)'
| /home/jwilk/openfst-1.5.3+r2/src/test/algo_test.cc:48:(.text+0x674): relocation truncated to fit: R_MIPS_CALL16 against `time@@GLIBC_2.0'
| /home/jwilk/openfst-1.5.3+r2/src/test/algo_test.cc:49:(.text+0x6a4): additional relocation overflows omitted from the output
| collect2: error: ld returned 1 exit status
| Makefile:641: recipe for target 'algo_test_log' failed

Appending "-mxgot" to CXXFLAGS fixed this error.
Inconveniently, "-mxgot" is not a valid option on hurd, so you'll have 
to add another ifneq.

Minor stylistic nitpick: I find

 ifneq "$(foobar)" ""

much more readable than

 ifneq (,$(foobar))


[1] https://lists.debian.org/20160418195914.GA5901@jwilk.net


> Do you think phonetisaurus [0] can also be uploaded to unstable?
>
> [0] https://anonscm.debian.org/cgit/collab-maint/phonetisaurus.git

I'll have a look at it later.

--
Jakub Wilk