[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825236: RFS: openfst/1.5.3-1 -- weighted finite-state transducers library



Control: tags -1 + moreinfo

* Giulio Paci <giuliopaci@gmail.com>, 2016-05-24, 23:38:
https://anonscm.debian.org/git/collab-maint/openfst.git

The package FTBFS (on i386):

| Making check in test
| make[3]: Entering directory '/build/openfst-aOvp6g/openfst-1.5.3/src/test'
| /usr/bin/make  fst_test weight_test algo_test_log algo_test_tropical algo_test_minmax algo_test_lexicographic algo_test_power
| make[4]: Entering directory '/build/openfst-aOvp6g/openfst-1.5.3/src/test'
| g++ -DHAVE_CONFIG_H   -I./../include  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O0 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -c -o fst_test.o fst_test.cc
| /bin/bash ../../libtool  --tag=CXX   --mode=link g++  -g -O0 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11  -fPIE -pie -Wl,-z,relro -Wl,-z,now -o fst_test fst_test.o ../lib/libfst.la -lm -ldl
| libtool: link: g++ -g -O0 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/fst_test fst_test.o  ../lib/.libs/libfst.so -lm -ldl
| g++ -DHAVE_CONFIG_H   -I./../include  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O0 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -c -o weight_test.o weight_test.cc
| /bin/bash ../../libtool  --tag=CXX   --mode=link g++  -g -O0 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11  -fPIE -pie -Wl,-z,relro -Wl,-z,now -o weight_test weight_test.o ../lib/libfst.la -lm -ldl
| libtool: link: g++ -g -O0 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/weight_test weight_test.o  ../lib/.libs/libfst.so -lm -ldl
| g++ -DHAVE_CONFIG_H   -DTEST_LOG -Wdate-time -D_FORTIFY_SOURCE=2  -g -O0 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -c -o algo_test_log-algo_test.o `test -f 'algo_test.cc' || echo './'`algo_test.cc
| In file included from algo_test.cc:6:0:
| ./algo_test.h:9:24: fatal error: fst/fstlib.h: No such file or directory
| compilation terminated.

(I tested 1.5.3-1, but I don't see anything changed in 1.5.3+r2-1 that would fix it...) Please reduce optimization level to -O0 only on architectures where it is strictly required. Otherwise there's a risk that bugs that only trigger with optimization enabled go under our radar even on mainstream archs.

I'm fine with uploading openfst to unstable.

BTW, while supporting as many architectures as possible is of course a desirable goal, supporting all of them is not strictly necessary. Stretch RC policy[0] says: “Packages must autobuild without failure on all architectures on which they are supported. Packages must be supported on as many architectures as is reasonably possible. Packages are assumed to be supported on all architectures for which they have previously built successfully. Prior builds for unsupported architectures must be removed from the archive (contact -release or ftpmaster if this is the case).”

Since openfst would be a new package in unstable, missing mips* builds wouldn't be release-critical or block testing migration.

[0] https://release.debian.org/stretch/rc_policy.txt

--
Jakub Wilk


Reply to: