[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#800406: RFS sayonara/0.8.2



Hi Ross,

I carefully read through your instructions and uploaded the package to https://mentors.debian.net/package/sayonara

Additionally, I made changes in:

debian/control:
 * called wrap-and-sort
* reduced dependencies to a minimum (the runtime dependencies have to stay the way they are, otherwise the database cannot be opened) * increased the standards-version to 3.9.8 (as it was proposed by the lintian output at the mentors page)

debian/watch:
 * Updated the watch file

debian/rules
* Changed the build environment, so the debian/rules file is reduced to a minimum, too

debian/source/format
 * Changed to 3.0 (quilt)

Source code:
 * Added copyright header and owner to all source files
* Removed spell errors due to the output of spellcheck --quiet-level=3 (only for languages I am used to)
 * Removed shell scripts
 * Had a look at the files where flawfinder found potential errors
 * Checked for (/home, /opt, /srv) references

license.txt
 * Removed license.txt
As some other distributions strictly want this file, I wanted to ask if I may remove that file with a debian patch?

Are there some further details I should check?

I have a question referring to the version numbering and bugfixes:
At the moment I am used to fix bugs applying to all distributions in upstream. The naming scheme of the version number currently is: sayonara_{VERSION}+git{DATE}-{DEBIAN_REVISION}, e.g. sayonara_0.8.3+git20160508-1. Bugfixes won't affect the version itself, but the git{DATE} part. So the watch file will indicate that a new version is available.

If there are debian-specific changes I'll use quilt and the debian revision number will increase. Is that common praxis?

So the next step will be to join the multimedia-team?

Greetings and have a nice Sunday,

Lucio


On 05/04/2016 07:50 PM, Ross Gammon wrote:
Hi Lucio,

On 05/04/2016 11:25 AM, Lucio Carreras wrote:
Hello Gianfranco, hello Ross,

unfortunately, the last message went to my spam folder so I just saw it
today. Gianfranco, thank you for having a look at the package. I will
correct those errors. But you are right, there are some some packaging
problems anyway.
I had wondered... You are welcome to ask here on the mentors list if any
of the packaging problems are proving difficult to fix. Don't be
embarrassed - we have all asked stupid questions here, and learnt from
other peoples questions. Glad it was the Spam folder and not the too
hard basket :-)

gstreamer1.0-plugins-ugly, libqt5sql5-sqlite < -- aren't them picked up by shibs:Depends?
Those libraries are loaded on runtime. The program will start without
them, but it won't work as intended. They are not available because the
build process does not depend on them.
OK. Looked strange to me too once Gianfranco mentioned it (especially
the sqlite library), but seems reasonable.

please just call dh_auto_configure and patch the build system to automatically take care of the flags.

I think all the rules hacks can be dropped.
There was a reason for including these rules. But I'll try to get rid of
them.

And thank you Ross for supporting the package. I guess, I'll need your
help from time to time.
Sure. Once the package is almost ready for upload, I recommend joining
the Debian Multimedia Team and maintaining the package there (in their
git repository). I would be happy to co-maintain it with you. I will be
hoping that you get so good at it that you won't need much help after a
while :-)

Cheers,

Ross



Reply to: