Bug#814456: RFS: pam-ufpidentity/1.0-debian2~unstable [ITP] -- UFP Identity PAM Module
control: owner -1 !
control: tags -1 moreinfo
control: block -1 by 812728
Hi, pam-ufpidentity review:
single changelog entry, please
upstream doesn't provide a license
^^^ showstopper, upstream should clearly indicate in the source tarball
the license used.
copyright: please use the same name for the copyright owner on debian
and upstream parts (nitpick, yeah)
control:
priority: optional
std-version 3.9.7
uncomment vcs stuff and move it to https
"pam-ufpidentity" <-- I don't see an install file, so I presume this
package would be empty.
please double check the packages you build.
missing shlibs:Depends on the pam-ufpidentity? the hard pam-ufpidentity1
hard dependency is really needed?
maintainer: please use the full name as in the copyright file
description: too short probably
README.txt: mostly empty, please be more verbose.
BTW do you really need to ship as debian/docs file?
and of course don't list it twice.
debian/*.install
*.so lib/${DEB_HOST_MULTIARCH}/security/
I would appreciate a sane build system, installing it directly in the
multiarch location, for the benefit of other linux distros.
(so remove dh-exec from b-d too).
a simple cmake file can do the job in a few lines
debian/*.dirs <-- please remove and mkdir them upstream
Makefile: bad makefile is bad. Doesn't have an install target, doesn't
take care of DESTDIR variable, not taking care of LDFLAGS CPPFLAGS and
so on, CC/CXX (clang e.g.)
having a simple cmake script might be trivial and easier to maintain
and please don't use =, but ?=
so e.g.
CC?=gcc is fine, because if the user doesn't have it set, it will
default to gcc.
(making life easier for clang users or other kind of users)
no soname?
rules: ignore-missing-info... why?
the source code seems little and trivial, does Debian really need this tool?
(I don't want to package a tool with 100 LOC, with no good reason)
let me know if you can address the above points.
cheers,
G.
On Thu, 11 Feb 2016 10:17:21 -0800 Richard Levenberg <richardl@ufp.com>
wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "pam-ufpidentity"
>
> * Package name : pam-ufpidentity
> Version : 1.0-debian2~unstable
> Upstream Author : Richard Levenberg <richardl@ufp.com>
> * URL : https://github.com/ufpidentity/pam_ufpidentity
> * License : GPL-2+
> Section : libs
>
> It builds those binary packages:
>
> pam-ufpidentity - Package UFP Identity PAM module
> pam-ufpidentity1 - PAM library for UFP identity
>
> To access further information about this package, please visit the
> following URL:
>
> http://mentors.debian.net/package/pam-ufpidentity
>
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x
> http://mentors.debian.net/debian/pool/main/p/pam-ufpidentity/pam-ufpidentity_1.0-debian2~unstable.dsc
>
> More information about pam-ufpidentity can be obtained from
> https://github.com/ufpidentity/pam_ufpidentity.
>
> Changes since the last upload:
>
> pam-ufpidentity (1.0-debian2~unstable) unstable; urgency=low
>
> * adding named package
>
> -- richardl <richardl@ufp.com> Tue, 09 Feb 2016 11:28:41 -0800
>
> n.b. This package has a dependency on
>
> http://mentors.debian.net/package/identity4c
>
> One can also download this package with dget using this command:
>
> dget -x
> http://mentors.debian.net/debian/pool/main/i/identity4c/identity4c_1.0-debian1~unstable.dsc
>
> More information about hello can be obtained from
> https://github.com/ufpidentity/identity4c
>
> Changes since the last upload:
>
> identity4c (1.0-debian1~unstable) unstable; urgency=low
>
> * building with sbuild
>
> -- richardl <richardl@ufp.com> Thu, 04 Feb 2016 00:36:51 -0800
Reply to: