Bug#812728: identity4c review
Hi (copy pasting the review from the wrong 814456 bug)
control: owner -1 !
control: tags -1 moreinfo
changelog: one single entry, with closes and the bug number.
(mentors allows to reupload the same version overriding the old one)
control: please enable VCS fields and in https mode.
std-version 3.9.7
dev package shouldn't be priority extra
"libc6-dev | libc-dev," <-- what?
misc pre-depends can be dropped post jessie
Priority: required? <-- what?
please consider checking the -dev package for multiarch
Depends: libxml2 <-- isn't this picked up by shlibs:Depends automagicall
y?
please remove and double check the dependency to be there into the
built deb file (sbuild is fine to build cleanly)
description + verbose please
docs: NEWS file shouldn't be there (it is empty)
*.dirs: they shouldn't be there, please patch upstream to create the
directories (for the benefit of people not using the deb packaging to
build) and other distro flavours
*-dev.install: why you don't install a pkgconfig file?
(I didn't check if upstream provides one)
please remove commented lines
rules: please remove commented stuff
check-all-the-things:
- - fine :)
copyright:
so much stuff is missing:
grep license . -Ri
./strmap.c: * the Free Software Foundation, either version 3 of the
License, or
./picohttpparser.c: * The software is licensed under either the MIT
License (below) or the Perl
picohttpparser.c: MIT/X11 (BSD like)
picohttpparser.h: MIT/X11 (BSD like)
strmap.c: LGPL (v3 or later)
strmap.h: LGPL (v3 or later)
grep copyright . -Ri
lots of missing stuff
lintian checks from DebOMatic (I already fixed parts of the control
file, e.g. removing libc-* and libxml*
http://debomatic-amd64.debian.net/distribution#unstable/identity4c/1.0-d
ebian1~unstable/lintian
W: identity4c source: debhelper-but-no-misc-depends identity4c
I: identity4c source: debian-watch-file-is-missing
please bother upstream about tagging a release, and/or use a
versioning such as
0.1~git2016blah- and so on
W: libufpidentity1-dbgsym: debug-file-with-no-debug-symbols
usr/lib/debug/.build-id/97/3cc9fa4127697649902121ccd7f43587f706cc.debug
not sure about this, maybe debug it if you have time :)
I: identity4c: extended-description-is-probably-too-short
^^ already told
W: identity4c: empty-binary-package
^^ please fix
X: identity4c: package-contains-no-arch-dependent-files
it's all for now :)
(note: I didn't install/test, but anyway, the package is already in a
good shape, most of the points above are really trivial to solve and
the overall fixing should take less than one hour or two)
good job!
cheers,
G.
Reply to: