[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#812922: RFS: classic-theme-restorer/1.4.6.1-1 [ITP] -- customize the new Iceweasel look



On Thu, Jan 28, 2016 at 09:18:25PM +0100, Jakub Wilk wrote:
> I don't intend to sponsor this package, but here's a quick review:

Thanks for the review.

> * Sean Whitton <spwhitton@spwhitton.name>, 2016-01-27, 14:43:
> >http://mentors.debian.net/debian/pool/main/c/classic-theme-restorer/classic-theme-restorer_1.4.6.1-1.dsc
> 
> The Homepage field looks broken:
> 
> $ grep-dctrl -ns Homepage '' debian/control | xargs wget -nv
> https://addons.mozilla.org/en-US/firefox/addon/classic-theme-restorer/:
> 2016-01-28 21:14:54 ERROR 404: NOT FOUND.

Fixed, thanks.

> Please consider using amo-changelog(1) for generating a less dummy
> upstream changelog.

Done -- nice tool!

> Typos: positiom -> position ootion -> option overriden -> overridden

These are all in comments in upstream's code; I don't think it's worth
submitting patches upstream for these non-user-visible typos.

> Why is debian-watch-may-check-gpg-signature overridden?  (You can
> answer by adding a comment to the override file.)

Comment added (signatures not provided; request made to upstream).

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: