[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#809623: RFS: telegram-purple/1.2.3-1

Control: tags -1 - moreinfo


thanks for taking a look at this package :D

I'm not sure if anybody picked up the work for this bug, but lets do
another review:

- -please drop commented default stuff from rules file
- -please merge changelog in one single entry
  (also "mentors" is not a target series)

These (and only these; see below) are already fixed in 1.2.4-2, which was uploaded 8 days ago [1]

I guess I did something wrong if you haven't seen that, even though I thought it should be done this way. Can you tell me what I should do differently next time?

- -please drop rawtar and genorigtar.sh, they seem useless with the
current watch file.

They generate the orig tarball.
The watchfile is to check for the newest version.
These are unrelated things.

As already documented in d/README.source, the orig-tarball can't be gathered from the obvious sources:
- Github (definitely)
- pristine-tar (definitely)
- git-buildpackage (afaik)
They all fail for the same reason: missing support for submodules within submodules. (Or gbp simply requires more setup than I thought.)

I know and agree that d/genorigtar.sh and d/rawtar are ugly, and they will be dropped in the next version, in favor of relatively clean chaining of git-archive and tar --concatenate. (Obviously not part of the build process, so no need to put any of that into Build-Depends.)

- -please use autoreconf and b-d on dh-autoreconf if possible

I'm not entirely sure what you mean by this.

Currently, we assume that the builder eventually invokes ./configure with whatever arguments he pleases and the usual semantics. This approach does not need anything explicit in d/rules. autoreconf is only called when we change configure.ac, in which case the new configure-script will be put into git. At no point, there's a need for the "user" (here: builder) to call auto{,re}conf.

Oh. Maybe the entry "autotools-dev" in Build-Depends is superfluous, then?

On a side note: 1.2.4 isn't going to make it anyway. Apparently, it's horribly unstable on Windows.

Ben Wiederhake
[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809623#79

Reply to: