[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#809451: sponsorship-requests: librep/0.92.5-1 [ITA]

Replying inline:

On 31/12/15 12:42, Mattia Rizzolo wrote:
> control: tag -1 moreinfo
> control: owner -1 !
> On Wed, Dec 30, 2015 at 08:00:11PM +0000, Jose M Calhariz wrote:
>> So I am searching for
>> someone that can help sponsor the packages, close the ITA and help me
>> fix the last bits for making the packages fit for Debian.
>> The packages are very old.  I can't update sawfish without updating
>> it's build-depends so starting with librep.  The latest changes are
>> on collab-maint and being tested in two of my PC for since August.
> ok, there a bunch of things I'd like to see before uploading this.
> * d/control:
>   + bump standards-version to the last policy release, 3.9.6
>     - this also requires adding stuff to d/rules.  maybe just use dh?
>   + canonicalize Vcs-* (for -Browser please use https)

Canonicalize?  Ha, I found an example on google.

> * use source/format 3.0 (quilt)
>   + so drop quilt build-dep
>   + and also the include in d/rules can go
>   + note: I won't upload stuff without d/source/format without a very
>     good reason.


> * d/README.source is outdated.  moreover if you move to 3.0 (quilt) you
>   can just drop it.


> * d/rules:
>   + the DEB_BUILD_OPTIONS thing about noopt can go, afaik dpkg takes
>     care of it nowadays

>   + please use dh-autoreconf (aka, #744619, you even have a patch!)

Modified the patch, but follow most of it.
>   + can you use the short dh format?  (I can even live without, it's
>     just I prefer quite more dh over plain debhelper)

I have learned to use debhelper and dh does too many magic things for
me.  Until I
understand better how packaging works I will give priority to debhelper
over dh.

>   + for the 'version' variable, please use `dpkg-parsechangelog -S`
>     instead of sed

I don like sed too.  But the replacement is different because that
variable name "version"
is a misnomer.

I am stuck on the next changes.  I will read documentation to understand
what better
what I  need to do. Meanwhile I am publishing my changes to collab-maint
so anyone can
review it.

>   + I didn't really check, but do you really need to do such mess by
>     generating the .install files at build time?  seems, well... doesn't
>     *look* needed, at least.

It is an inheritante from the past.

> * you have a librep9.symbols, probably you should rename it, and update
>   to have the newer symbols, and remove the old ones.
> * please bump to debhelper compat 9
>   + this will also make (or at least help) make the lib multiarch-able
>     - for this to work you need to start using dh_auto_configure instead
>       of manual calling ./configure, though
>     - note that with this several .install will need an update
>     - I see you already had troubles with --host and --build configure
>       flags: 1) I wonder why you need --host at all, we are not
>       cross-compiling... 2) dh_auto_configure takes care of --build.
>     - suggestion: stop fiddling so much, and use dh + dh_auto_configure.
> * librep-dev.links => no, please.  linking /usr/share/doc/<pkg>
>   directory ain't nice at all, why is that in first place?
>   + but if you don't want to change it now it's fine, note that just
>     removing it and let dh take care of it isn't enough, you need a
>     maintscript for that
>   + I see there already are preinst snippet to remove the directory.  my
>     reaction to this is: wtf?  it does so quite unconditionally and -.-'
> * d/copyright:
>   + I'd appreciate a DEP-5 copyright format (but I can live without)
> * trailing whitespaces:
>   + d/rules:46
> it seems that this upload is going to start a library transition.
> If so, then you need to upload to experimental, and follow
> https://wiki.debian.org/Teams/ReleaseTeam/Transitions or, am I missing
> something?

The only revert depends are the sawfish and rep-gtk.  But lets follow
the transitions guidelines and start by
uploading it to experimental.

Kind regards
Jose M Calhariz

Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: