On Thursday 31 December 2015 08:57 PM, Mattia Rizzolo wrote:
> control: owner -1 !
> control: tag -1 moreinfo
>
> [ please don't do top posting ]
>
> On Sat, Oct 17, 2015 at 03:26:35PM +0530, Bhuvan Krishna wrote:
>> Fixed all the bugs. Please check the package and suggest any changes.
>>
>> https://mentors.debian.net/package/php-mf2
> Ok, so, some more things, and then we're good:
>
> * you depend on 'php (>=5.3.0)', but 'php' is a metapackage, currently
> * at version 17. what you want is just 'php5' (the version constraint is
> really useless, debian has 5.3 in old-old-stable).
> + Actually, you don't really need it at all. ${misc:Depends} +
> ${phpcomposer:Debian-require} expand to 'php5-cli, php5-common (>=
> 5.3.0)' by themselves, so the 'php' depends is just noise.
> * you got a trailing whitespace at line 2 of d/copyright
> + while at it, I don't like wasting bytes on pointeless newlines, mind
> removing the lines 9 and 10 of that file, so you have only 1 empty
> line? :)
> * please tell upstream that "MIT" as a license is kinda ambiguos. What
> you wrote in d/copyright is better referred to as "Expat". Then, I
> don't know if in the php world is used to just call that "MIT".
> * the maintainer is PHP PEAR, don't they mandate the use of a VCS?
> + I genuinely don't know.
- Set myself as maintainer until I get added to PEAR team.
- Remove php5 as dependency since ${misc:Depends}
${phpcomposer:Debian-require} already expand to dependency on
php5-common and php5-cli.
- Remove a trailing whitespace and unnecessary blank lines in copyright
file. Added missing new line at the end of the file.
- Changed license in copyright file to Expat license. Contacted
upstream for license rename.
>
Attachment:
signature.asc
Description: OpenPGP digital signature