Bug#795771: RFS: dblatex/0.3.7-1

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Hi Andreas,



>thanks again for your review.  I have uploaded dblatex-0.3.7-2 to


first nitpick: not needed to upload a -2 version. using the same -1
is fine and works until the real upload (on Debian ftp-master) is
performed

>Sorry to disagree with your first suggestion (terrible start, I know):


there is no "terrible start" for me :)

>Using a machine-readable copyright file is optional according to section>12.5.1 of the Debian Policy Manual.  In contrast to this idea I prefer
>to keep as close to the upstream copyright file as possible, thus simply
>diffing the upstream with the Debian file is enough to keep the latter

>synchronized with the former.

fine for me :)


>Anyway, I'm happy to comply and have changed according to your
>suggestion.


feel free to revert them back if your emacs is more satisfied
(I do not care about the evaluation part, since we talk about some
cpu cycles, but keep them as you like then, it is fine for me!)

>I have moved the retrieval of the examples tarball to the watch file and
>eliminated the get-orig-source target and all related stuff.  Indeed
>this simplifies the rules file remarkably.


ack
>You're right, done.

[...]

>Done.

wonderful
>Here I disagree again: dblatex-examples.tar.bz2 has been uploaded one
>time (in 2009) to SourceForge and hasn't changed since then, the archive
>is not versioned at all.  Thus IMHO it's overkill to use a separate
>package for this small, static add-on.


mmm what does it happen if they gets updated and you miss it because
there is no uscan detecting them?


I see that the watch file already takes care of them, unfortunately they
are not versioned, so we might not catch an update there...

this is usually bad, maybe ping upstream about adding an 1.0 somewhere
to avoid people missing examples updates
(but here we might really don't care about examples 10 years old never
updated)

BTW you might also use pypi to fetch your sources from
http://pypi.debian.net/dblatex

(there is also a watch file for the source tarball, you might want to use
it and add the examples part)

>Good idea, done.
thanks


>As you see, I've been happy to implement many of your findings, however
>I disagree with your vote on the machine-readable copyright file and on
>the package split.  I hope that you will nevertheless consider to
>sponsor this upload, although I would also understand if you forbear
>From=20sponsoring as you don't agree with my packaging decisions.


just to clarify, my view is not the right one, and your view is not the
bad one.

My view is a single view point in a community of 2k+ people, and disagreeing
with me is completely fine as long as we do not violate any policy rule ;)


we might differ just because I had already done some work for Debian already,
so I might foresee problems where a non DD usually don't look
(specially related to Debian packaging of course).

But as long as you can explain your point of view, I can agree for sure
if the explanation is good :)


(and this doesn't change usually my sponsoring effort)


Some other nitpicks:
I see you runtime-depends on python-apt, not sure why, but please consider
adding it to the 

install_requires section of setup.py and let python:Depends do its job :)


cheers,

G.