Bug#796030: RFS: tablesnap/0.7.2-1 [ITP] -- Backup utility for the Cassandra database
Control: owner -1 !
Lets review:
1) debian/changelog should only contain one entry.
Initial release (Closes: #ITPBUG)
2) debian/control: debhelper >=9 is recommended
3) d/control: "python-pyinotify, python-boto, python-dateutil, python-argparse"
they are all listed in setup.py install_requires so they should be added by python:Depends
automatically.
Please check and remove them
3) debian/compat: 9
4) what about using python3?
5) bonus: write a systemd service file.
6) d/copyright: please add the Debian packaging copyright
(even if it shouldn't be mandatory anymore)
after that we should be mostly good.
(note: I didn't build/install it, I will in the next review step)
cheers,
Gianfranco
Reply to: