Hi Jörg,
I am glad to see you working on this, as one of my packages will
eventually depend on python-instagram!
On 04/06/2015 11:31 PM, Jörg Frings-Fürst wrote:
>
>
> Please can someone review this package[1].
>
> Thanks.
>
> CU
> Jörg
>
> [1] http://mentors.debian.net/debian/pool/main/p/python-instagram/python-instagram_1.3.0+git20150406~e885e7d-1.dsc
>
>
Therefore, I thought I would give you a review for what it is worth (I
am not a DD so I cannot sponsor it):
- The package builds fine in a chroot and the clean target is working fine.
- piuparts reports no problems.
- Lintian is happy.
- The watch file is not working, but that is okay as upstream do not do
releases or tags.
I am wondering why d/control has "Provides: ${python:Provides}"? Python
Policy mentions it (and generally discourages its use). Mainly I am
curious about it.
One minor comment about d/copyright is that according to the upstream
README & LICENSE files, the copyright says "2014, Facebook, Inc." (not
Instagram, and not in 2015)
I also noticed that setup.py still says MIT (not reflecting the recent
change to BSD). You might want to report that upstream.
Here's hoping you find a sponsor soon.
Regards,
Ross
Attachment:
signature.asc
Description: OpenPGP digital signature