[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#808461: sponsorship-requests: mdp [ITP] -- command-line based markdown presentation tool



Hello Lev,

On 20 December 2015 at 12:06, Lev Lamberov <dogsleg@debian.org> wrote:
> * Package name    : mdp
>   Version         : 1.0.3
>   Upstream Author : Michael Goehler [email is not known yet]
> * URL             : https://github.com/visit1985/mdp
> * License         : GPL-3
>   Section         : misc
>
> It builds those binary packages:
>
>  mdp - command-line based markdown presentation tool
>
> To access further information about this package, please visit the following URL:
>
> https://anonscm.debian.org/cgit/collab-maint/mdp.git/

I will happily sponsor your package, but there's a couple of things
you need to fix.

i) Vcs-* fields are used to point users to the maintainer's Git, not
the upstream's one (I've fixed that for you).

ii) You should test the watch file using uscan to see if it's actually
working (in yours, filenamemangle wasn't right, I have also fixed that
for you).

iii) There's too much boilerplate in the rules file. Please remove
things which aren't actually used. It's also a good idea to make use
of .PHONY.

iv) Why are you overriding dh_compress?

v) In the changelog, there's Closes: #nnnn. Please put a proper number
there (#808072, I suppose)?

-- 
Cheers,
  Andrew


Reply to: