On Fri, Dec 11, 2015 at 08:47:15PM -0500, Jacob Adams wrote:
> On 12/11/2015 06:43 PM, Mattia Rizzolo wrote:
> > On Fri, Dec 11, 2015 at 05:19:01PM -0500, Jacob Adams wrote:
> >> On 12/06/2015 09:05 AM, Mattia Rizzolo wrote:
> How are you catching these? I don't mean to leave them and I don't mind
> fixing them, but I can't see trailing whitespace (because it looks like
> blank space :) ) and so seem to accidentally leave it everywhere.
I find trailing whitespaces quite annoying, they can too easily lead to
diff noise, can make unecessary hard to understand why a patch doesn't
apply between different versions, etc.
I set up vim (that's my editor :P) to show me them with a bullet.
listchars=trail:·
↑ this should be enough to show them.
> > Btw, you added 2 trailing whitespaces at line 5 and 11.
You got another one at line 12 :P
> >>> * even if you try to enable the hardening in d/rules, that doesn't work,
> >>> and blhc still complains (and also lintian)
> >> I'm not sure what to do about this. Should I just have a patch that
> >> appends $(shell dpkg-buildflags --get $VAR) for CFLAGS and LDFLAGS?
> > The problem is that that makefile overwrites CFLAGS from the env. This
> > is enough to deal with it (it's on top of the other patch of yours):
> >
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1,4 +1,4 @@
> > -CFLAGS = -DSHAPE -Wall -Werror -fPIC
> > +CFLAGS := $(CFLAGS) -DSHAPE -Wall -Werror -fPIC
> > LDLIBS = -lXext -lX11
> > BIN = $(DESTDIR)/usr/bin/
> >
> Ok I used that. Lintian still complains however, so I'm not sure what
> else to do.
This is weird. With that on both lintian and blhc shut up here.
Though not sure what you meant by "I used that", because it's not in the
patch in the package.
> >>> Please also triage the debian bugs:
> >>> + #681740 was fixed in 1.2-10
> >> Should I just close it?
> > yes, and also settinging the correct "fixed" value :)
> Ok I marked it as fixed in 1.2-10 and then closed it.
> Obviously I need to learn the BTS. The next thing I'll do for Debian is
> fix a few bugs in other packages to get the hang of it.
For example, to do that in one single email you could have:
* put control@ in (b)cc to the 681740-done@ email
* used the Version: pseudo-header, that when used in -done@ emails means
"this got fixed in this version". That's what happens with
automatically close emails at package uploads (even if those use
Source-Version instead of Version, but that's the same).
> Any other bits of Debian infrastructure I should learn? I'm relatively
> familiar with the package tracker and sources.
Guess that's good enough for now; just go around all the links that are
in tracker.d.o pages and you'll get a good overview.
Then if you haven't already please have a look at the policy and devref:
https://www.debian.org/doc/debian-policy/
https://www.debian.org/doc/manuals/developers-reference/
> > tools, guess you did packaging work somewhere else?
>
> I did some packaging before on a few things for Debian but never got a
> sponsor. In both cases I never got a response from upstream so I gave up
> as I felt overwhelmed by all the stuff I had to do. Third time's the
> charm I guess :)
:)
Maybe try again now? ;)
> I've add Author fields. Should I add you to the Author field of the
> CFLAGS patch?
No need.
So, there is only that thing about CFLAGS to sort out. Note that I'm
fine as it is now, btw, just tell me that ain't an error.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature