control: owner -1 !
control: tag -1 + moreinfo
Hi!
First, please be a bit more patiente with your pings; following up only
5 days later is very much not helpful.
On Wed, Nov 25, 2015 at 03:10:28PM -0500, Jacob Adams wrote:
> I am looking for a sponsor for my package "9wm"
>
> * Package name : 9wm
> Version : 1.3.4-1
> Upstream Author : Neale Pickett <neale@woozle.org>
> * URL : https://woozle.org/neale/g.cgi/x11/9wm
> * License : Expat
> Section : x11
The review:
* trailing whitespace on debian/control:29
* please be a lot more verbose on the changelog. "Redo packaging" is
not satisfactory at all. Every change should be documented.
* debian/patches/*: if possible a URL of the forwarded patch would be
nice
* debian/rules:
+ trailing whitespace at line 11
+ with debhelper compat 9 exporting the build flags that way is not
needed anymore, so lines 3-4-5 can go away
* you removed the postinst and prerm with the update-alternatives calls,
that looks useful to me; why?
* even if you try to enable the hardening in d/rules, that doesn't work,
and blhc still complains (and also lintian)
* From piuparts:
0m51.6s INFO: Running adequate version 0.12.1 now.
0m51.8s ERROR: WARN: Inadequate results from running adequate!
9wm: missing-alternative x-window-manager
0m51.8s ERROR: WARN: Running adequate resulted in inadequate tags found: missing-alternative
0m59.0s INFO: PASS: Installation and purging test.
1m1.2s INFO: apt-cache knows about the following packages: 9wm
1m8.3s INFO: Installation of ['tmp/9wm_1.3.4-1_amd64.deb'] ok
1m15.4s INFO: Running adequate version 0.12.1 now.
1m21.1s ERROR: WARN: Broken symlinks:
/usr/bin/x-window-manager -> /etc/alternatives/x-window-manager
/usr/share/man/man1/x-window-manager.1.gz -> /etc/alternatives/x-window-manager.1.gz
/etc/alternatives/x-window-manager.1.gz -> /usr/share/man/man1/9wm.1.gz
/etc/alternatives/x-window-manager -> /usr/bin/9wm
1m22.9s ERROR: FAIL: Package purging left files on system:
/etc/alternatives/x-window-manager -> /usr/bin/9wm not owned
/etc/alternatives/x-window-manager.1.gz -> /usr/share/man/man1/9wm.1.gz not owned
/usr/bin/x-window-manager -> /etc/alternatives/x-window-manager not owned
/usr/share/man/man1/x-window-manager.1.gz -> /etc/alternatives/x-window-manager.1.gz not owned
1m22.9s ERROR: FAIL: Installation, upgrade and purging tests.
1m24.3s ERROR: piuparts run ends.
Please also triage the debian bugs:
+ #681740 was fixed in 1.2-10
+ #349680 not sure what to do, but sice you're becoming the maintainer
that's your call. probably the best course of action, given where
the links in that bug end, is to just close the bug.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature