control: owner -1 !
On Sun, Dec 06, 2015 at 10:17:33PM -0500, Tong Sun wrote:
> HI Mattia, thanks for the reivew.
Hi, and sorry if this sounded confused.
These are actually my first big public review than will lead to an
upload by me, and I figured is hard to grasp everything.
Also I noticed I didn't specified what I (personally) require for an
upload and what instead is just "nice to have", and what is just
"pointless nitpick".
I'll try to be more precise. :)
> On Sun, Dec 6, 2015 at 12:32 PM, Mattia Rizzolo wrote:
Ok, I'm ok with some changes being missing, even if I'm that kind of> > On Fri, Nov 20, 2015 at 11:47:21PM -0500, Tong Sun wrote:
> > > http://mentors.debian.net/debian/pool/main/d/dbab/dbab_1.3.1-1.dsc
> > >
> > > Changes since last version:
> > >
> > > * New upstream release (1.3.1).
> > > - [!] make the pixelserv more robust
> > > - [!] fix dbab.service exec file name
> > > - [!] closes: #774191
> > > - [*] use dbab.md to replace dbab.html
> > > - [*] rename conf files to dbab.xxx (incompatible with previous
> > > version!)
> > > - [!] closes: #775253 by using conf files as
> > /etc/dnsmasq.d/dbab.xxx
> > > - [+] dbab.md add faq
> > > - [!] amend dbab.list- to reflect upstream list change
> > > - [*] update copyright year
> > > - [*] update git home
> > > - [+] add must-have Depends: dnsutils
> > > - [+] add "How to whitelist some sites" section to FAQ
> > > - [+] add blank-line-checking to dbab-get-list to prevent errors
> > > - [!] fix "dep5-copyright-license-name-not-unique"
> > > - [!] fix "missing-license-paragraph"
> >
> > well, the chaneglog in the downloaded source package from the .dsc up
> > there is different, it has less changes.
> >
>
> It has less entries, but that doesn't means it has less changes -- the
> one from the .dsc is more condensed, with less detailed, yet it covers
> everything. This one just elaborate more into details.
everything-must-be-the-changelog guy.
Anyway, I want addition of dnutils to the depends to be documented.(*)
> I find this way of maintaining the debian packaging of an non-native
> > thing quite difficoult to handle.
> >
>
> ..., debian/changelog is where you store debian-specific changes,
[...]
> You need to be more specific on what I should I do, please. Otherwise, I'm
> still at lost what I should be doing. So I took a look at the debian
> policy, and found it is quite OK to just keep one changelog file:
[...]
> In fact, you are the only one voicing concerns about the changelog file.
> Since it is quite common and clearly documented in debian policy, I don't
> need to do anything else more, right?
It's ok, yes; yet this is the first package I see that is non-netive,
share the maintainer, doesn't have upstream changelog, but the debian
changelog document upstream changes.
I don't require you do to anything, I'm just raising concerns.
For example: you get a bug which require you to change d/rules, and for
whatever reason you can't upload a new upstream version *now*, what do
you do? usually you bump the debian revision fixing it, you can do it,
but how do you handle it on the vcs, for example? It's totally up to
you, yeah, I'm just lost, but I'm totally fine if you're fine.
> Also, in the changelog you put two bugs, but #774191 is already closed,
> > and cited also in the previous changelog entry; and that changelog entry
> > reads:
> >
> > dbab (1.2.2-2) unstable; urgency=high
> >
> > * Targeting back to Debian Sid
> > * The reported wrong path problems was fixed in v1.2.1 (closes:
> > #774191)
> >
> > => bad. changelog entries should contains only changes for that
> > version, not for already released ones; just to add confusion, the
> > closing message in that bug says the bug is fixed only in 1.2.2-1 :S
> >
>
> Ok, Ok, Ok, that's a mistake, I shouldn't have listed there. I'll remove
> it. Again, please be clearer on what I should I do. Removing it is all I
> need to do, right?
yes, please remove the line 7 of the changelog, the one containing only
the closes: of an already closed bug. (*)
> > Also there is a checksum mismatch between what you released on github
> > and what's in mentors.d.n:
> > mattia@chase ~/devel/RFS/dbab % sha256sum dbab_1.3.1.orig.tar.xz
> > ~/Downloads/dbab-1.3.1.tar.gz
> > 805e4674e2e6e7622bcb1ad0a3bd9db669e8737e1dd2a22dc716346c50c64e6d
> > dbab_1.3.1.orig.tar.xz
> > 2ea7a1a2f6a664d397a926ace21e71e2745050f219bd7977921ec8b8a017db27
> > /home/mattia/Downloads/dbab-1.3.1.tar.gz
> >
> > please clarify.
> >
>
> One is .tar.xz file, and the other is .tar.gz, so the checksum will
> definitely be different. Moreover, not only the checksum are different, the
> content are different too. I'll put the .orig.tar.xz file in the release on
> github. That will solve the problem right?
Indeed.
Is not required, but usually we try to upload to the archive the very
same tarball upstream releases (for more: for example there is work in
progress to be able to upload to the debian archive the detached
upstream signature of the tarball - #759401)
Given you're upstream I've got no questions this time, but please would
be nice if you can release the very same thing in all the places.
> > I suggest you to try another way of handling the upstream development,
> > like keeping a 'debian' branch, where you then merge upstream tags, and
> > where you keep the debian/ directory (clearly you remove it from
> > master).
> >
>
> This is for the future, and doesn't affect this release right? Honestly,
> what you've described is quite complicated, far more complicated than the
> simple method that I'm doing. Thanks for the suggestion though, but it is
> so complicated that I really can't apprehend it, so I'll keep to my simple
> method for now, unless it is blocking the release.
No, it's not blocking anything.
But I assure you, is not hard at all :)
Also think about other distributions. Nowadays I believe most of them
got ways to ignore distro-specific stuff, but for example years ago it
used to be a issued for us if upstream had an "debian" directory on the
tarball.
You might be interested to read https://wiki.debian.org/UpstreamGuide
> > More detailed information about changes can be obtained from
> > > https://github.com/suntong/dbab/commits/master.
> >
> > Then I've issue to read the commits from github, but that's my problem
> > ;)
>
>
> Sorry, I'm lost again. I don't really quite understand what you are trying
> to say here, as English is not my first language.
>
> But anyway, I know you are trying to help, and I'm really appreciate that.
In this last paragraph I was just kidding: I personally don't like the
github interface :)
So, just fix the 2 tiny changelog issues marked with (*) and I'd be
happy to upload it!
The rest is just food for thought :)
Sorry again if I made you feel lost, etc.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-