Bug#805707: RFS: dbab/1.3.1-1 [new version update]

HI Mattia, thanks for the reivew.

On Sun, Dec 6, 2015 at 12:32 PM, Mattia Rizzolo wrote:

control: tag -1 + moreinfo

Hi!

On Fri, Nov 20, 2015 at 11:47:21PM -0500, Tong Sun wrote:
> http://mentors.debian.net/debian/pool/main/d/dbab/dbab_1.3.1-1.dsc
>
> Changes since last version:
>
> * New upstream release (1.3.1).
> - [!] make the pixelserv more robust
> - [!] fix dbab.service exec file name
> - [!] closes: #774191
> - [*] use dbab.md to replace dbab.html
> - [*] rename conf files to dbab.xxx (incompatible with previous
> version!)
> - [!] closes: #775253 by using conf files as /etc/dnsmasq.d/dbab.xxx
> - [+] dbab.md add faq
> - [!] amend dbab.list- to reflect upstream list change
> - [*] update copyright year
> - [*] update git home
> - [+] add must-have Depends: dnsutils
> - [+] add "How to whitelist some sites" section to FAQ
> - [+] add blank-line-checking to dbab-get-list to prevent errors
> - [!] fix "dep5-copyright-license-name-not-unique"
> - [!] fix "missing-license-paragraph"

well, the chaneglog in the downloaded source package from the .dsc up
there is different, it has less changes.

It has less entries, but that doesn't means it has less changes -- the one from the .dsc is more condensed, with less detailed, yet it covers everything. This one just elaborate more into details.

I find this way of maintaining the debian packaging of an non-native
thing quite difficoult to handle.

..., debian/changelog is where you store debian-specific changes,
for upstream stuff there should be some kind of other changelog outside
debian/, which will then automatically installed by dh_installchangelog
in /usr/share/doc/dbab/ alongside debian's changelog. See devref and/or
policy for this.

You need to be more specific on what I should I do, please. Otherwise, I'm still at lost what I should be doing. So I took a look at the debian policy, and found it is quite OK to just keep one changelog file:

If the package has only one changelog which is used both as the Debian changelog and the upstream one because there is no separate upstream maintainer then that changelog should usually be installed as /usr/share/doc/package/changelog.gz;

In fact, you are the only one voicing concerns about the changelog file. Since it is quite common and clearly documented in debian policy, I don't need to do anything else more, right?

Also, in the changelog you put two bugs, but #774191 is already closed,
and cited also in the previous changelog entry; and that changelog entry
reads:

dbab (1.2.2-2) unstable; urgency=high

* Targeting back to Debian Sid
* The reported wrong path problems was fixed in v1.2.1 (closes: #774191)

=> bad. changelog entries should contains only changes for that
version, not for already released ones; just to add confusion, the
closing message in that bug says the bug is fixed only in 1.2.2-1 :S

Ok, Ok, Ok, that's a mistake, I shouldn't have listed there. I'll remove it. Again, please be clearer on what I should I do. Removing it is all I need to do, right?

Also there is a checksum mismatch between what you released on github
and what's in mentors.d.n:
mattia@chase ~/devel/RFS/dbab % sha256sum dbab_1.3.1.orig.tar.xz ~/Downloads/dbab-1.3.1.tar.gz
805e4674e2e6e7622bcb1ad0a3bd9db669e8737e1dd2a22dc716346c50c64e6d dbab_1.3.1.orig.tar.xz
2ea7a1a2f6a664d397a926ace21e71e2745050f219bd7977921ec8b8a017db27 /home/mattia/Downloads/dbab-1.3.1.tar.gz

please clarify.

One is .tar.xz file, and the other is .tar.gz, so the checksum will definitely be different. Moreover, not only the checksum are different, the content are different too. I'll put the .orig.tar.xz file in the release on github. That will solve the problem right?

I suggest you to try another way of handling the upstream development,
like keeping a 'debian' branch, where you then merge upstream tags, and
where you keep the debian/ directory (clearly you remove it from
master).

This is for the future, and doesn't affect this release right? Honestly, what you've described is quite complicated, far more complicated than the simple method that I'm doing. Thanks for the suggestion though, but it is so complicated that I really can't apprehend it, so I'll keep to my simple method for now, unless it is blocking the release.

> More detailed information about changes can be obtained from
> https://github.com/suntong/dbab/commits/master.

Then I've issue to read the commits from github, but that's my problem
;)

Sorry, I'm lost again. I don't really quite understand what you are trying to say here, as English is not my first language.

But anyway, I know you are trying to help, and I'm really appreciate that.

Thanks