[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: general question about quilt patch handling



On Sat, Nov 28, 2015 at 03:00:47PM +0100, Werner Detter wrote:
> short question by example: quilt series contains several patches, e.g.
> 
> 1.patch
> 2.patch
> 3.patch
> 4.patch 
> 
> let's assume 3.patch which worked for some time but will be no longer functional
> because the 3.patch uses a function which will not available in future versions 
> of dependency software (like libnet-dns-perl). 
> 
> what's the recommendation here? 
> 
> a) delete 3.patch completly and create a new quilt patch for the fix
> b) leave 3.patch untouched and just create a new one which fixes the changes
>    from 3.patch? 
> c) something else? 

This is up to you, but one possible criteria would be to try to be
nice with upstream.

For example, if 3.patch has not been forwarded upstream yet, then I
would definitely modify it (instead of creating a new patch).

That way upstream would receive a single patch about the issue, not a
patch and a patch for the patch.


Reply to: