[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#805656: RFS: node-leaflet-hash/0.2.1-1 [ITP]



On 11/20/2015 09:30 PM, Ross Gammon wrote:
> On 11/20/2015 09:16 PM, Sebastiaan Couwenberg wrote:

[...]

>> I pushed some changes to document the license & copyright for the
>> embedded copy of leaflet-src.js, and update the Vcs-Browser URL to use
>> HTTPS.
>>
>> Why do you install lib/leaflet-src.js?
> 
> npm2deb did it for me!
> 
>>
>> It seems to be included only for its use in test/index.html, and that
>> test isn't used by the package. I don't think this files needs to be
>> installed, and if it does libjs-leaflet should be used instead.
> 
> Hmmm. I think you might be right. A libjs-leaflet package probably
> should be added, with the test directory installed so users can run the
> test in the browser. README.md is not to helpful on this, so I will give
> it a go and report back.

Scratch that. I missed your words above - "embedded copy of
leaflet-src.js". We already have libjs-leaflet in the archive, so
another package of the same name is not a good idea!

As we can't run a HTML test in the browser during the build, your first
suggestion of not installing the embedded copy may be better.

Cheers,

Ross

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: