[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#805656: RFS: node-leaflet-hash/0.2.1-1 [ITP]



On 11/20/2015 09:16 PM, Sebastiaan Couwenberg wrote:
> Hi Ross,
> 
> Thanks for your work on this package.
> 
> On 20-11-15 20:25, Ross Gammon wrote:
>> I am looking for a sponsor for my package "node-leaflet-hash"
> 
> I pushed some changes to document the license & copyright for the
> embedded copy of leaflet-src.js, and update the Vcs-Browser URL to use
> HTTPS.
> 
> Why do you install lib/leaflet-src.js?

npm2deb did it for me!

> 
> It seems to be included only for its use in test/index.html, and that
> test isn't used by the package. I don't think this files needs to be
> installed, and if it does libjs-leaflet should be used instead.

Hmmm. I think you might be right. A libjs-leaflet package probably
should be added, with the test directory installed so users can run the
test in the browser. README.md is not to helpful on this, so I will give
it a go and report back.

> Kind Regards,
> 
> Bas
> 

Thank you :-)

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: