Bug#804801: RFS: libjdns/2.0.3-1 [ITP]
Hi,
thank you again for your review!
> 1) changelog: urgency=low would be preferred for a new package
Done.
> 2) control:
> libqjdns-qt5-2, can't it be called libqjdns2-qt5 maybe?
I know the name is not so nice, but I used the named lintian claimed out.
> So I guess you can remove the "libjdns2" dependency because it should be taken care of in shlibs:Depends(please check the built package, inside DEBIAN/control file)
Oh sorry, this is a relict of the divided package. Fixed.
> 3) debian/rules: it looks really nice, maybe I would override the clean target to remove the build directories.
Done.
> 4) if possible I would ask you to use MIT, the same as upstream (that way everybody might be able to forward patches from you
> without asking to relicense them)
Yes, of course! I forgot the incompatibility between MIT and GPL-3+.
> 5) you ship usr/bin/jdns as part of libqjdns-qt4 package, but ldd shows that links qt5 stuff.
> ldd jdns |grep Qt5 -i
> libqjdns-qt5.so.2 => not found
> libQt5Network.so.5 => not found
> libQt5Core.so.5 => /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5 (0xf7230000)
>
>
> so please choose: move in the qt5 package, move in the base package (maybe dropping the qt stuff), or fix it somewhat else.
>
> this "problem" makes the qt4 package drag all the qt5 dependencies.
I've fixed it by using the cmake option "-DBUILD_JDNS_TOOL=OFF" for the
Qt5 build. And so only the Qt4 version will be build in a separate
package called "jdns".
> oh and please convert your package to multiarch (needs investigation and a probable trivial change)
> https://wiki.debian.org/Multiarch/Implementation
> (be careful about usr/bin)
Converted and tested. Only usr/bin/jdns is a problem and so I decided to
separate the test program into another package.
> lintian:
> X: libqjdns-qt5-2: application-in-library-section libs usr/bin/jdns
> W: libqjdns-qt5-2: binary-without-manpage usr/bin/jdns (help2man is a good starting point)
I've created and added a manpage based on the /usr/bin/jdns output. It's
not the best, but I hope it's ok.
> $ codespell --quiet-level=3
> ./CMakeLists.txt:91: prefered ==> preferred
The codespell error only occurrs in the CMakeList and so it is not
important for a normal users.
Kindly Regards,
Stefan
Reply to: