[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#804947: RFS: inform/6.31.1+dfsg-2



Hi,

On Fri, 2015-11-13 at 16:36 +1100, Ben Finney wrote:
> Package: sponsorship-requests
> Severity: wishlist
> Control: tags 698980 + pending
> Control: block 698980 by -1
> 
> I am looking for a sponsor for my package ‘inform’:

Since I've used inform before, I had a small look at the package.
However, I'm not a DD so I can't upload it for you.

[...]
> This release contains the following significant changes:
> 
>   * Updated packaging to resolve Lintian errors.
>   * Prepare for switch to free software upstream versions.
> 
> Once this updated release is sponsored, I intend to collaborate with
> upstream and package their later free software versions.

Why can't you package the later free versions now?

The package FTBFS when build with dpkg-buildpackage -B:
> dpkg-buildpackage: source package inform
> dpkg-buildpackage: source version 6.31.1+dfsg-2
> dpkg-buildpackage: source distribution unstable
> dpkg-buildpackage: source changed by Ben Finney 
>  dpkg-source --before-build inform-6.31.1+dfsg
> dpkg-buildpackage: host architecture amd64
>  fakeroot debian/rules clean
> dh_testdir
> dh_testroot
> rm -f build.stamp unpack.stamp
> rm -f inform-6.31.1/config/config.guess
> rm -f inform-6.31.1/config/config.sub
> [ ! -f inform-6.31.1/Makefile ] || /usr/bin/make -C inform-6.31.1/ maintainer-clean
> dh_clean
>  debian/rules build-arch
> dh_testdir
> cd inform-6.31.1/ && ./configure --prefix=/usr
> checking for a BSD-compatible install... /usr/bin/install -c
> checking whether build environment is sane... yes
> checking for gawk... no
> checking for mawk... mawk
> checking whether make sets $(MAKE)... yes
> configure: error: cannot run /bin/bash config/config.sub
> debian/rules:49: recipe for target 'build.stamp' failed
> make: *** [build.stamp] Error 1
> dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2

From the build log for dpkg-buildpackage -b (which does work):
> In file included from linker.c:9:0:
> linker.c: In function ‘write_link_byte’:
> header.h:618:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>  #define subtract_pointers(p1,p2) (((int32) p1)-((int32) p2))
>                                     ^
> linker.c:968:9: note: in expansion of macro ‘subtract_pointers’
>      if (subtract_pointers(link_data_top,link_data_holding_area)
>          ^

This looks pretty bad for any 64-bit architecture to me. My guess is
that it still works due to pure luck that glibc's allocator doesn't
start at an address above 2GB. The code is also wrong for 32-bit since
it could potentially result in signed integer overflow if addresses in
the 2GB-3GB range are used.

debian/Makefile.upstream:
 What is the purpose of this file?

debian/rules:
 Why not use dh?
 Why not use dh_autoreconf?

James

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: