[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#801197: RFS: smplayer-themes/1:15.6.0-1



Hi, sorry but I still see the changelog changed back

http://anonscm.debian.org/cgit/pkg-multimedia/smplayer-themes.git/commit/debian/changelog?id=2183ac2a374344fca702793a588a30a97607a744

dget -u http://mentors.debian.net/debian/pool/main/s/smplayer-themes/smplayer-themes_15.6.0-1.dsc
dget -x http://http.debian.net/debian/pool/main/s/smplayer-themes/smplayer-themes_14.9.0-1.dsc
debdiff smplayer-themes_14.9.0-1.dsc smplayer-themes_15.6.0-1.dsc > debdiff
filterdiff  debdiff -i "*debian*" > debdiff.filtered






--- smplayer-themes-14.9.0/debian/changelog     2014-10-04 11:19:53.000000000 +0200
+++ smplayer-themes-15.6.0/debian/changelog     2015-11-07 21:10:06.000000000 +0100
@@ -1,8 +1,23 @@
-smplayer-themes (1:14.9.0-1) unstable; urgency=medium
+smplayer-themes (1:15.6.0-1) unstable; urgency=medium

* New upstream release.
* debian/control:
+    - Bump Standards-Version to 3.9.6. (no changes needed)
- Add myself to uploaders.
+  * Use qt5 to build.
+  * debian/copyright: convert to dep5.
+  * Add debian/patches/use-usr-as-prefix.patch to use /usr as prefix.
+
+ -- Mateusz Łukasik <mati75@linuxmint.pl>  Sat, 07 Nov 2015 21:10:03 +0100
+
+smplayer-themes (1:14.9.0-1) unstable; urgency=medium
+
+  [ Alessio Treglia ]
+  * Upload to unstable.
+
+  [ Mateusz Łukasik ]
+  * New upstream release.
+  * debian/control:
- Bump minimal debhelper version.
- Bump Standards Version (no changes needed).
- Use canonical VCS fields.



and the patch debian/patches/use-usr-as-prefix.patch

should be not this way

-PREFIX=/usr/local
+PREFIX=/usr

but this other way
-PREFIX=/usr/local
+PREFIX?=/usr/local


and upstreamed.

that way if nobody sets prefix it will be defaulted to /usr/local.

of course in rules file you need something like
export PREFIX=/usr


(changing PREFIX to prefix in Makefile should make the export useless, and the Makefile
behave correctly)

cheers,

G.



Il Sabato 7 Novembre 2015 21:15, Mateusz Łukasik <mati75@linuxmint.pl> ha scritto:
On 06.11.2015 16:29 +0100, Gianfranco Costamagna wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hi!
>
> ping, if you are still interested, please answer and fix the above :)
> (or ask about how to fix it)
>
> otherwise I'll close the RFS and unassign myself :)
>
> cheers,
>
> G.
>
> On Wed, 7 Oct 015 16:40:18 +0000 (UTC) Gianfranco Costamagna
> <costamagnagianfranco@yahoo.it> wrote:
>> Hi,
>>
>>> dh_usrlocal:
>>> debian/smplayer-themes/usr/local/share/smplayer/themes/Oxygen-KDE/Oxy
> gen-KDE.rcc
>>>   is not a directory dh_usrlocal:
>>> debian/smplayer-themes/usr/local/share/smplayer/themes/Oxygen-KDE/REA
> DME.txt
>>>   is not a directory rmdir: failed to remove
>>> 'debian/smplayer-themes/usr/local/share/smplayer/themes/Oxygen-KDE':
>>>   Directory not empty dh_usrlocal: rmdir
>>> debian/smplayer-themes/usr/local/share/smplayer/themes/Oxygen-KDE
>>>   returned exit code 1 debian/rules:6: recipe for target 'binary'
>>> failed
>>
>>
>>
>> mmm changing Makefile from PREFIX=/usr/local to PREFIX?=/usr/local
>>
>> should work.
>>
>> cheers,
>>
>> G.
>>
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJWPMdxAAoJEPNPCXROn13ZyXUP/j21Cnx32C0Zbn3nvPRGTPSz
> veQ8jXQQ8EjuMm6T9t0OYVFgkMN4FCm/+9csU4Mmo9cLqqJBTR+NTXVBLjNntJJH
> AFEgYnfq/5yRMEMsTZJtSB4pRqDJByrB64Pw9rHTIahpdLhu9aNHawKMUaJludmV
> 35uvRkcZBlwAGBQ9JGsng839faEc4PTVfIeqZqLPqpahtvScn+a2vWhR1O5l+lPu
> 80wEYbsoFiEX6LIG58cvOanG/k/ggmYOny7uGmo3SuP1PXNr+lsGudKgxZPlMQOM
> NLeT3cjYqRpyVP52jGPx2J7HvVklDWwrIO+TNW4gDwHSVL+Ixh33WAU1c2gUk/9e
> o3rIAoDtDrb2px5ElAVbE+ZOEahSTw326U2DecUdyOBd1fgjm25lRRzifhqHhYZf
> zwuv5StkdyNpHot441DkHKXnvcHPrQrjVx/SZW6F6tRsZyLYUwHeUk34fNWwAD6Z
> Uil6LVvnsGXSQQEcIyHUMnTRcJdC61OFkxtL2o7FtdKeTXbXc3J0qPfGTJYf/ENg
> 2fYw+hse5DPALEnM93gbviYc8lC59U5V2UL9mJj0b9TjkQ9jJ5DNn5Rndlbq77Xc
> vR+dcBBps334K4qjEshE2vX4BRBLNAiCB1q9Zzwb35CwvKHvp1tF78bHgHLuesAG
> w1XS1BCn4TxOcXaCp7mv
> =0uXp
> -----END PGP SIGNATURE-----

>

Hi,

Fixed version is uploaded to mentors:

http://mentors.debian.net/debian/pool/main/s/smplayer-themes/smplayer-themes_15.6.0-1.dsc

Mateusz


Reply to: