[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#787861: review: polyml



Hi Gianfranco,
Thank you for continuing to look at this. I have just uploaded the newest version (5.5.2-1~rc1) to https://mentors.debian.net/package/polyml.

1) I have sent a request to join debian-science. Presumably I should wait until the package is ready to be uploaded before requesting an upload?
2) By this do you mean change it from an NMU to a team upload in the changelog? If so, I have done that.

3) Added
4) Merged

5) Removed
6) It had it before (https://packages.debian.org/sid/amd64/polyml/filelist). It is in fact required by the new “polyc” compiler executable (a shell script; the output binary is linked against libpolymain) which is currently part of the “polyml” binary package.
7) I know it fails to build on hurd-i386 (due to a lack of PATH_MAX), which I plan to fix and submit upstream. However, I imagine it probably does build on a lot of the other architectures that aren’t listed.
8) There are no reverse dependencies as far as I can tell (other than the various packages built by this source package)

> debian:polyml-5.5.2 james% apt-cache rdepends polyml libpolyml1 libpolyml-dev
> polyml
> Reverse Depends:
> libpolyml1
> Reverse Depends:
>   polyml
>   libpolyml-dev
> libpolyml-dev
> Reverse Depends:
> debian:~ james% reverse-depends -b src:polyml
> No reverse dependencies found

9) The entirety of libffi/ is licensed under the MIT license, and is a copy of the source for https://sourceware.org/libffi/, apart from some unlicensed files in its test suite, and a few other files:

> debian:polyml-5.5.2 james% licensecheck * -r | grep -v 'GENERATED FILE$' | grep -v 'LGPL (v2.1 or later)$' | grep -v '^libffi/.* MIT/X11 (BSD like)$' | grep -v '^libffi/testsuite/libffi\.call.*\*No copyright\* UNKNOWN$'
> libffi/msvcc.sh: MPL (v1.1) GPL (unversioned/unknown version)
> libffi/texinfo.tex: GPL (v3)
> libffi/build-ios.sh: *No copyright* UNKNOWN
> libffi/testsuite/libffi.special/ffitestcxx.h: *No copyright* UNKNOWN
> libffi/testsuite/libffi.special/unwindtest.cc: *No copyright* UNKNOWN
> libffi/testsuite/libffi.special/unwindtest_ffi_call.cc: *No copyright* UNKNOWN
> libffi/ltmain.sh: GPL (v2 or later)
> libffi/include/ffi_common.h: UNKNOWN
> libffi/generate-osx-source-and-headers.py: *No copyright* UNKNOWN
> libffi/src/m68k/ffi.c: *No copyright* UNKNOWN
> libffi/src/dlmalloc.c: *No copyright* UNKNOWN
> libffi/generate-ios-source-and-headers.py: *No copyright* UNKNOWN
> libpolyml/realconv.cpp: UNKNOWN
> ltmain.sh: GPL (v2 or later)
> wininstall/polyicon/polyicon.c: *No copyright* UNKNOWN

I have added an entry to debian/copyright listing libffi as MIT; is this sufficient?

10) Removed
11) Changed

Thanks,
James

> On 13 Oct 2015, at 18:46, Gianfranco Costamagna <costamagnagianfranco@yahoo.it> wrote:
> 
> Control: owner -1 !
> Control: tags -1 moreinfo
> 
> Hi James,
> 
> 1) please join the debian-science team and ask them an ack for the upload
> 2) please convert in team upload the package
> 
> 3) please close 561763 in the changelog
> 4) please merge the two changelogs together
> 
> 5) please remove rules.old
> 6) the polyml.install shouldn't have the static library, right?
> 7) "i386 sparc powerpc amd64 armel armhf" do you have any reason for not trying to build on "any"?
> 8) did you test reverse dependencies?
> 
> apt-cache rdepends package
> 
> reverse-depends -b src:package
> can give you some hints
> 
> 
> 9) licensecheck * -r shows many licenses not LGPL-2.1+
> 10) debian/menu please remove (menu is deprecated since a month or two)
> 11)
> usr/share/man/man1/poly.1*
> usr/share/man/man1/polyc.1*
> usr/share/man/man1/polyimport.1*
> 
> 
> 
> they belong to dh_installmanpages, not dh_install
> 
> the other stuff might look good, I still need to check a build&run of the package.
> 
> cheers,
> 
> G.
> 
> 
> Il Mercoledì 7 Ottobre 2015 12:21, James Clarke <jrtc27@jrtc27.com> ha scritto:
> Hi,
> I believe I have addressed the changes you mentioned in http://mentors.debian.net/debian/pool/main/p/polyml/polyml_5.5.2-0.2.dsc, and would be grateful if you could please review it.
> 
> Thanks,
> James
> 
> 
>> On 6 Oct 2015, at 10:54, James Clarke <jrtc27@jrtc27.com> wrote:
>> 
>> Firstly sorry for not replying, I hadn’t subscribed to the bug so I was never emailed a copy of your message.
>> 
>> I figured it wasn’t really common to have NMUs like this, but given the fact that the package is not orphaned but its maintainers have not replied to bug reports, I thought this was one of the few options; I don’t really care how the newer versions are uploaded, so long as they get uploaded eventually!
>> 
>> As far as I can tell from `apt-cache depends`, nothing outside of the polyml source package depends on any of the binary packages in it.
>> 
>> 1) makes sense to go via experimental
>> 2,3,4) I shall see what I can do
>> 
>> In case you couldn’t tell I’m very new to this, so thanks for taking the time to go through the details.
>> 
>> Thanks,
>> James
>> 
>>> On 25 Sep 2015, at 17:32, Gianfranco Costamagna <costamagnagianfranco@yahoo.it> wrote:
>>> 
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA256
>>> 
>>> Hi, this is really too much for an NMU.
>>> 
>>> Did you test reverse dependencies?
>>> 
>>> you are bumping shlibs, so you need to be sure to have requested a
>>> transition slot on release.debian.org (use reportbug against it to ask
>>> one).
>>> 
>>> I would do rather a team upload instead, and I would appreciate:
>>> 
>>> 1) an upload to experimental to test rebuilds
>>> 2) converting to dh format
>>> 3) use of autoreconf instead of autotools-dev
>>> 4) convert to multiarch?
>>> 
>>> I can check the other things later if you still are interested.
>>> 
>>> cheers,
>>> 
>>> G.
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG v2
>>> 
>>> iQIcBAEBCAAGBQJWBXcZAAoJEPNPCXROn13Z3roP/2GHZv1CWdA2K4/74IfvY3/+
>>> vfCcXVKLp31bgaa41tTvV2oV2dSbAiTlqSUwnZFJygFaqp6eXuweVVPdf0cT5IfV
>>> ZTG3w3n0JcK/u/cgu0nvHm6Cy/ENb9LD/YIRJ7ZTI8u5AiiVpGGAc+WY0j9150Bc
>>> NyWYw8HMFxav3tR6vPjh0R2I1QgN7WjHbZLmgIqlaJbZgjqMu1O4lYzhfn/wL3ub
>>> LcJYCHk0BI5pB48ABfx7fLs0DrvOaEoQ63l5mM1uX6BgpAiXdAQSY5qE5enUSH6a
>>> Aq60l7E3DxeKERUnTuGMRj3529abSDRxteAMMTP2IlXoKYV2h5XHCJlLmbjunKV1
>>> KDAqwoZGQpia81jM6hKdZbbbOZfpzzevW14yj2x0qYQEVyMv+7lSDP6p1o7VHYyL
>>> zSNKGzquIGcCeTkDQ1pTeuYm3HPsuIjmXD1saG2qInE6F9ccie0n8AT8WEInGGMd
>>> UHcBu/cHhyyBiThUcZhgQEuU+Pf1kRy0f9SbPTibFtlvKf3HOgB2DD018WK7JFBB
>>> rF46I2Jr4V5TbHh3nmPhJhk46MFjDyxfOW9rE60jpeJcopMoK6xBUTBlM1mwQrud
>>> JGrjUztjgDd8BX+/LDzr4IZXPc67LcQghrYAUOgzNhe/jAI9gnsp0JTi7rwaEN82
>>> hm7eOneGezYiwC18gEFH
>>> =tPZ/
>>> -----END PGP SIGNATURE-----
>>> 
>> 

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail


Reply to: