Re: ldconfig in a post(rm|inst) script

[Herbert Parentes Fortes Neto (hpfn) <hpfn@ig.com.br>]

Hi Mattia,

> On Tue, Oct 06, 2015 at 04:10:20PM +0200, Jakub Wilk wrote:
> > * Herbert Parentes Fortes Neto <hpfn@ig.com.br>, 2015-10-06, 09:33:
> > >>>libgphoto2-6.postrm
> > >>>remove)
> > >>>	rm -f /usr/share/hal/fdi/information/20thirdparty/$PACKAGE.fdi || true
> > >>>	rm -f /usr/share/hal/fdi/information/10freedesktop/10-camera-$PACKAGE.fdi || true
> > >>>	rm -f /usr/share/hal/fdi/information/10freedesktop/10-camera-$PACKAGE-device.fdi || true
> > >>>	ldconfig
> > >>>	;;
> >
> > debhelper takes care of calling ldconfig, but of course it won't rm any
> > files for you.
> > 
> > BTW, you almost certainly don't want to ignore errors by using these "||
> > true" things.
> 
> Also, to me it looks really weird removing /usr/share/hal/* files.
> 
> According to my `apt-cache file` search (with a quite old cache,
> admittely, I'm currently not in a good enough network to update it) no
> packages shipt those file (well, maybe the first if $PACKAGE is right,
> which I don't think is the case?)
> 
> % apt-file search /usr/share/hal
> barry-util: /usr/share/hal/fdi/information/10freedesktop/10-blackberry.fdi
> barry-util: /usr/share/hal/fdi/policy/10osvendor/19-blackberry-acl.fdi
> libmtp-common: /usr/share/hal/fdi/information/20thirdparty/20-libmtp9.fdi
> libsane-common: /usr/share/hal/fdi/preprobe/10osvendor/20-libsane.fdi
> ntfs-3g: /usr/share/hal/fdi/policy/10osvendor/25-ntfs-3g-policy.fdi
> 
> What are those files you're removing there?
> 

Good point. I also search[0] and found nothing that libgphoto2
should mess with.

[0] - https://packages.debian.org/search?suite=sid&arch=any&mode=path&searchon=contents&keywords=.fdi

Sorry if you receive much email directly. The email to mentors
was returning and I resending it. I noted that to late.

I upload the package to mentors.
http://mentors.debian.net/package/libgphoto2
http://mentors.debian.net/debian/pool/main/libg/libgphoto2/libgphoto2_2.5.8-2.dsc

The debian/changelog is like this:

 * debian/control:
      - set debhelper version >= 9.20151005. To be sure not use
        ldconfig on post(rm|inst) scripts.
        Thanks Mattia Rizzolo
  * debian/rules:
      - var SHLIBS updated to 2.5.7
      - override for dh_strip to stop "unstripped-static-library"
        Thanks Alex Vong.
  * debian/libgphoto2-6.postrm:
      - remove the '|| true'.
        Thanks Jakub Wilk and Alex Vong
  * debian/upstream/signing-key.asc:
      - right key now.

I put a version for debhelper because lintian still
complain about ldconfig.


regards,
-- 
Herbert Parentes Fortes Neto (hpfn)