Bug#790816: RFS: roxterm/3.0.1-1

[Vincent Cheng <vcheng@debian.org>]

Hi Tony,

On Tue, Jul 7, 2015 at 6:07 AM, Tony Houghton <h@realh.co.uk> wrote:
> On 07/07/15 09:21, Vincent Cheng wrote:
>
>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position
>> 836: ordinal not in range(128)
>>
>> debian/rules:36: recipe for target 'override_dh_auto_build' failed
>>
>> I've attached the full build log.
>
>
> I think the problem is that the PC you tried the build on doesn't have utf8
> as its default encoding, so I need to enforce that in the script. This would

That's really more of a "problem" caused by pbuilder (which enforces
LANG=C and LC_ALL=C). If you aren't doing so already, please do test
build your package with pbuilder/cowbuilder/sbuild.

> need to apply upstream too so I think the best way is to change mscript.py
> with the attached patch. Would you be able to test that for me before I
> upload a new version?
>

Unfortunately your patch makes d/rules clean fail for me:

$ pdebuild --debbuildopts '-d'
dpkg-checkbuilddeps: Unmet build dependencies: librsvg2-bin libvte-2.91-dev po4a
W: Unmet build-dependency in source
dpkg-buildpackage: source package roxterm
dpkg-buildpackage: source version 3.0.1-1
dpkg-buildpackage: source distribution unstable
dpkg-buildpackage: source changed by Tony Houghton <h@realh.co.uk>
 dpkg-source --before-build roxterm-3.0.1
dpkg-source: info: using options from
roxterm-3.0.1/debian/source/options: --extend-diff-ignore=\.pot?$
dpkg-source: info: applying mscript.py.encoding.diff
 fakeroot debian/rules clean
dh clean
   dh_testdir
   debian/rules override_dh_auto_clean
make[1]: Entering directory '/tmp/roxterm/roxterm-3.0.1'
python3 mscript.py clean --lock-top --build-dir=debian/build
--top-dir=../.. --src-dir='${TOP_DIR}/src'
Traceback (most recent call last):
  File "mscript.py", line 4, in <module>
    reload(sys)
NameError: name 'reload' is not defined
debian/rules:48: recipe for target 'override_dh_auto_clean' failed

However, I was able to build your package just by adding "export
LC_ALL=C.UTF-8" to d/rules. I can upload your package with this
change, or if you'd rather fix this upstream, that's fine with me as
well.

Regards,
Vincent