Bug#790816: RFS: roxterm/3.0.1-1
Control: tag -1 + moreinfo
Control: owner -1 !
Hi Tony,
On Wed, Jul 1, 2015 at 1:22 PM, Tony Houghton <h@realh.co.uk> wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "roxterm"
>
> * Package name : roxterm
> Version : 3.0.1-1
> Upstream Author : Tony Houghton <h@realh.co.uk>
> * URL : http://roxterm.sourceforge.net
> * License : GPL2+
> Section : x11
>
> It builds these binary packages:
>
> roxterm - Multi-tabbed GTK+/VTE terminal emulator - binaries
> roxterm-data - Multi-tabbed GTK+/VTE terminal emulator - data files
> roxterm-dbg - Debugging symbols for roxterm
> roxterm-gtk3 - Multi-tabbed GTK+/VTE terminal emulator - transitional
> package
> roxterm-gtk3-dbg - Multi-tabbed GTK+/VTE terminal emulator - transitional
> package
>
> To access further information about this package, please visit the following
> URL:
>
> http://mentors.debian.net/package/roxterm
>
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x
> http://mentors.debian.net/debian/pool/main/r/roxterm/roxterm_3.0.1-1.dsc
>
> More information about roxterm can be obtained from
> http://roxterm.sourceforge.net
>
> Changes since the last upload:
>
> roxterm (3.0.1-1) unstable; urgency=medium
>
> * Updated Standards-Version to 3.9.6.
> * Build uses python3 (updated Build-Depends accordingly).
> * Upstream tarball now uses .xz compression.
> * Added Select All menu item.
> * Allow unlimited scrollback lines.
> * Fixed some unsafe uses of sprintf.
> * Provide option to rewrap text when terminal width changes.
> * Drop support for GTK2 etc (Closes: #790183).
> * Reorganized surviving binary packages.
> * Use vte-2.91 API (Closes: #788028).
>
> -- Tony Houghton <h@realh.co.uk> Wed, 01 Jul 2015 18:50:46 +0100
>
> roxterm (2.9.7-1) unstable; urgency=low
>
> * Fixed colour/shortcut shceme CLI switch clash.
> * Fixed --tab aiming to target most recently focused window.
>
> -- Tony Houghton <h@realh.co.uk> Mon, 30 Mar 2015 18:24:17 +0100
>
> roxterm (2.9.6-1) unstable; urgency=low
>
> * debian/copyright: Added .ycm_extra_conf.py.in.
> * Fade text in unselected tabs.
> * Fix maximise and full screen buttons in profile.
>
> -- Tony Houghton <h@realh.co.uk> Thu, 08 Jan 2015 21:16:21 +0000
>
> I thought I had released 2.9.6-1 and 2.9.7-1 via sponsorship too, but
> for some reason the current version in unstable is still 2.9.5-1. Is the
> changelog OK as above or should I merge these entries?
Please merge the above d/changelog entries.
I just skimmed the debdiff between 2.9.5-1 and your package on mentors
and noticed a few small things:
- your newly added d/copyright stanza for ".ycm_extra_conf.py.in" has
a License: GPL-3+ header, but the license body references GPL-2
multiple times.
- d/rules: CFLAGS = $(shell dpkg-buildflags | grep '^CFLAGS=') is
quite brittle; I suggest using dpkg-buildflags --get CFLAGS instead
(ditto for CPPFLAGS and LDFLAGS)
Regarding your package split, have you tested other possible upgrade
scenarios? There's a few scenarios I can think of that are broken or
not ideal:
- A user who just has roxterm-gtk2 installed (and roxterm-common
auto-installed), without the roxterm metapackage, will not get any
updates because both of these packages are no longer built from
src:roxterm
- A user has roxterm-gtk2 and roxterm-gtk2-dbg installed. Aside from
the same problem as the first scenario, if he/she now chooses to
apt-get install roxterm-dbg, (I think) dpkg will explode due to file
conflicts between roxterm-gtk2-dbg and roxterm-dbg.
And perhaps other scenarios as well, but that's all for now since my
lunch break is over. :)
You should actually keep around dummy transitional packages for every
single package that's currently no longer being built from
src:roxterm. That's probably the simplest way of making sure all
possible upgrade scenarios work (+ double checking package
inter-relationships are correct).
Regards,
Vincent
Reply to: