Hi there! Thanks for reaching out. The Games Team is probably the best place to maintain this package indeed. I myself maintain two console emulators there: zsnes and vba. VBA-M is a good addition, way more recent than VBA. It's more maintained and more accurate: http://tasvideos.org/EmulatorResources/GBAccuracyTests.html It is not entirely clear whether it should replace VBA. What do you think? If it is so, it will probably be worth making an upgrade path so that existing vba installs are converted to vba-m (this does not have to be in your initial upload). I mostly agree with the first review, so I won't go in details over this. > > * You probably want a versioned dependency from vbam-gtk and vbam > > -wx to vbam-common. > > vbam-common has only icons, so I don't understand the need for this. This is needed for upgrades. It makes it impossible to have vbam-sdl 1.9 installed together with vbam-common 1.8. > > W: vbam source: missing-license-paragraph-in-dep5-copyright > > public-domain > (paragraph at line 36) > > I don't understand this warning, "public-domain" isself explanatory > and it's not a license at all. I'm trying to understand the text > below from the copyright-format page, but I'm not fluent in the > english language. They should add an example to clarify: > > "When the License field in a paragraph has the short name > public-domain, the remaining lines of the field must explain exactly > what exemption the corresponding files for that paragraph have from > default copyright restrictions." "Public domain" is unfortunately ambiguous, and in some countries it does not even exist. That is why it is need to be clarified. Generally speaking, as an author it is a good idea to use CC0 which explicitly describes these rights. In your case, adding a short description "These files have been put in the public domain by their author" may be enough. Feel free to CC me in your replies and I'll be happy to make the next review once those issues are fixed! And thanks for working on VBA-M! -- Etienne Millon
Attachment:
signature.asc
Description: Digital signature