Bug#787223: RFS: vbam/1.8.0.1498-1
Hi!
> general
> * Have you considered maintaining the package as part of the
> Debian Games team?
> * Have you contacted Etienne Millon <>?
> He may be interested in this (as the maintainer of the vba
> package).
I just tried on #debian-games, I will contacted Millon.
> d/control:
> * Why are there 2 GUI frontends to this package?
Wx is the new multi-platform frontend and it has many features/options,
GTK+ was the old frontend with few options.
> * You probably want a versioned dependency from vbam-gtk and vbam
> -wx to vbam-common.
vbam-common has only icons, so I don't understand the need for this.
> * The version of vba in the archive has a dependency from vba-gtk
> to vba. Does this package need that?
vbam-gtk and vbam-sdl are independent.
> * The trademark disclaimer probably doesn't need to be in the
> description, but you can put it in d/copyright if you want (I
> don't know how necessary it is).
It's Nintendo, so it's better to have this disclaimer.
> * The files licensed under GPL-2 only are problematic since there
> is some GPL-3 files here as well. The files must be replaced or
> re-licensed with permission of the author(s). If they aren't
> used, then copyright file should say that.
src/filters/hq/asm/macros.mac is only used if NASM is enabled, so I
think there is no problem (I put a comment in the Copyright file). About
the other files (Array.h and RingBuffer.h), I think upstream is fixing
it right now.
> W: vbam source: missing-license-paragraph-in-dep5-copyright
public-domain (paragraph at line 36)
I don't understand this warning, "public-domain" isself explanatory and
it's not a license at all. I'm trying to understand the text below from
the copyright-format page, but I'm not fluent in the english language.
They should add an example to clarify:
"When the License field in a paragraph has the short name public-domain,
the remaining lines of the field must explain exactly what exemption the
corresponding files for that paragraph have from default copyright
restrictions."
> vbam-sdl segfault
> I tried running a game with vbam in the vbam-sdl package. When closing
> the program it segfaulted. This was the stacktrace. As you can see,
> fclose was called with a NULL pointer.
I think it's better to report bugs directly on upstream, I already
reported your issue: https://sourceforge.net/p/vbam/bugs/178/
Thanks for the feedback! I already updated the packaging.
--
Sérgio Benjamim
Reply to: