[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#783225: Review



Harlan Lieberman-Berg <hlieberman@setec.io> wrote:
> - There's some misspellings in the code -- most notably, "abilty"
>   instead of "ability" in various places, and "distrubution" instead of
>   "distribution" in the README.md.

Upstream has merged my pull request that fixes these spelling mistakes.

https://github.com/baedert/corebird/commit/e999a8477cf2bc0e24817307c233141cf970e37f

> - msgfmt reports many fatal errors and warnings for the .po files -
>   mostly empty msgstr's, but some others.  Use `msgfmt --check
>   --check-compatibility --check-accelerators --output-file=/dev/null
>   {FILE}` to find these errors.  You can also use POFileChecker from
>   gettext-lint to find more problems.

I don't know much about gettext. I will learn more and either fix these
problems or report them upstream

> - Most importantly, this package fails to build in a clean chroot.  It
>   looks like it's missing a build-dep on intltool, maybe?  The log is
>   attached.

I've added intltool to the build-dep line in debian/control. I'm going to do
more testing to ensure the package builds in a chroot.

> Thanks again for your help!  

Thanks for reviewing my package!
-- 
Edward.


Reply to: