[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#783277: RFS: gnome-exe-thumbnailer/0.9.3 [ITP]



Control: owner 783277 !

Hi James,

On Fri, 24 Apr 2015 17:52:29 -0700, James Lu <GLolol1@hotmail.com> wrote:
> I am looking for a sponsor for my package "gnome-exe-thumbnailer"
> 
>   * Package name    : gnome-exe-thumbnailer
>     Version         : 0.9.3
>     Upstream Author : 2010-2012 Jan Nekvasil <jan.nekvasil@ryant.cz>
>                       2009-2010 Christian Dannie Storgaard
> <cybolic@gmail.com> 2009-2012 Scott Ritchie <scottritchie@ubuntu.com>
>   * URL             : http://wiki.winehq.org/exe-thumbnailer
>   * License         : LGPL-2.1+
>     Section         : gnome
> 
> Changes since the last upload:
> 
> gnome-exe-thumbnailer (0.9.3) unstable; urgency=medium
> 
>    * Initial Debian release, forked from Ubuntu. (Closes: #767376)

Note that the version uploaded to Debian might end up replacing that in
Ubuntu.

>    * Update debian/ files:
>       - Set myself as maintainer.
>       - Bump to debhelper 9.

You need to change the value in debian/compat as well as the version in the
build-dependency.

>       - Remove outdated gconf2 build-dependency, depend on libglib2.0-bin
>         instead (for theme fetching).
>       - Remove unnecessary dependency on python.
>       - Update Standards Version to 3.9.6.
>       - Set priority to optional from extra.
>       - Include my changes in debian/copyright.

The declarations aren't quite right; you don't need the years after
"Copyright:", so simply

Files: *
Copyright:
 2010-2012 Jan Nekvasil ...

Also, did you receive the source by email, or did you download it from
Ubuntu? The "Source:" states the former but it's the same in Ubuntu, so I'm
guessing you need to change that ;-).

>       - Remove /usr/share/gconf/schemas from dirs file.
>       - Explicitly set source/format to 3.0 native. This is what the Ubuntu
>         packaging seems to suggest, as there is only one .tar.gz
>         file available for download.

The Ubuntu packaging is indeed native, as indicated by debian/source/format;
but this isn't a native package (a native package is a package which contains
software written specifically for Debian). I'd rather you changed
debian/source/format to "3.0 (quilt)" and used 0.9.3-1 as package version;
that would also avoid issues upgrading from the Ubuntu version of the
package. (Copy Ubuntu's .tar.gz to gnome-exe-thumbnailer_0.9.3.orig.tar.gz.)

Could you also fix the following lintian issues?

* P: gnome-exe-thumbnailer source: unversioned-copyright-format-uri
  http://dep.debian.net/deps/dep5

(The URI should be
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
currently.)

* I: gnome-exe-thumbnailer: capitalization-error-in-description-synopsis
  Gnome GNOME
* I: gnome-exe-thumbnailer: capitalization-error-in-description Gnome GNOME
* W: gnome-exe-thumbnailer: binary-without-manpage
  usr/bin/gnome-exe-thumbnailer

Finally, it might be worth packaging this within the Wine packaging team, if
you'd care to join us...

Regards,

Stephen

Attachment: pgpog7gPiGrGd.pgp
Description: OpenPGP digital signature


Reply to: