On Sat, 2015-04-18 at 18:02 -0400, Michael Zahniser wrote: > Thanks for the quick feedback! > > If SSE 4.1 is not acceptable, is it possible to at least depend on SSE > 3? I use some SSE intrinsics to optimize geometric calculations. Should > I modify the code so those instructions are used only if a special > command line option is given? That would mean all the official packages > would be un-optimized, even though all i386 and amd64 processors from > the last decade support SSE 3. Nope you can't assume SSE 3 is present. You can only assume SSE 2 and only on amd64 (not i386). If you want to use something newer, you can use a command line option like you said, or do runtime cpu detection. > For libjpeg, right now I use the JCS_EXT_BGRA option (converting to > 32-bit BGRA color when decoding JPEGs). The reason I specified > libpeg-turbo is because other libjpeg implementations may not include > that extension. (But, I see that libjpeg-turbo is the default > implementation of libjpeg on Debian, anyway.) Is it safe to just specify > plain libjpeg as the dependency? Ah I didn't know you used that - you can use libjpeg62-turbo-dev if you specifically want libjpeg-turbo. James > On 04/18/2015 04:33 PM, James Cowgill wrote: > > On Sat, 2015-04-18 at 14:31 -0400, Michael Zahniser wrote: > >> Dear mentors, > >> > >> I am looking for a sponsor for my package "endless-sky". > > > > Here are some comments: > > > > build: > > The build passes -msse4.1 to g++. This will fail on non-x86 arches and > > produce binaries which don't work without sse 4.1 processors on x86 > > arches. > > > > debian/control: > > libjpeg-turbo8-dev does not exist in debian, try libjpeg-dev > > Latest standards version is 3.9.6 > > > > debian/copyright: > > You need copies of CC-BY-SA-3.0 and CC-BY-3.0 > > > > debian/rules: > > You should not hardcode -j4 in the rules file. Use the value given in > > DEB_BUILD_OPTIONS 'parallel' instead (see policy 4.9.1). > > > > Lintian output: > > W: endless-sky: hardening-no-relro usr/games/endless-sky > > I: endless-sky: hardening-no-fortify-functions usr/games/endless-sky > > I: endless-sky: description-synopsis-might-not-be-phrased-properly > > I: endless-sky: hyphen-used-as-minus-sign usr/share/man/man6/endless-sky.6.gz:7 > > I: endless-sky: desktop-entry-lacks-keywords-entry usr/share/applications/endless-sky.desktop > > I: endless-sky-data: description-synopsis-might-not-be-phrased-properly > > P: endless-sky: no-upstream-changelog > > P: endless-sky-data: no-upstream-changelog > > > > The warning should be fixed. That one is usually caused by the build > > system ignoring custom CFLAGS/CXXFLAGS/etc. The others would be nice to > > fix as well but are not essential. > > > > Otherwise, the package looks good - I'm not a DD though so I can't > > upload the package for you when it's done. > > > > Thanks, > > James > >
Attachment:
signature.asc
Description: This is a digitally signed message part