On Sat, 2015-04-18 at 14:31 -0400, Michael Zahniser wrote: > Dear mentors, > > I am looking for a sponsor for my package "endless-sky". Here are some comments: build: The build passes -msse4.1 to g++. This will fail on non-x86 arches and produce binaries which don't work without sse 4.1 processors on x86 arches. debian/control: libjpeg-turbo8-dev does not exist in debian, try libjpeg-dev Latest standards version is 3.9.6 debian/copyright: You need copies of CC-BY-SA-3.0 and CC-BY-3.0 debian/rules: You should not hardcode -j4 in the rules file. Use the value given in DEB_BUILD_OPTIONS 'parallel' instead (see policy 4.9.1). Lintian output: W: endless-sky: hardening-no-relro usr/games/endless-sky I: endless-sky: hardening-no-fortify-functions usr/games/endless-sky I: endless-sky: description-synopsis-might-not-be-phrased-properly I: endless-sky: hyphen-used-as-minus-sign usr/share/man/man6/endless-sky.6.gz:7 I: endless-sky: desktop-entry-lacks-keywords-entry usr/share/applications/endless-sky.desktop I: endless-sky-data: description-synopsis-might-not-be-phrased-properly P: endless-sky: no-upstream-changelog P: endless-sky-data: no-upstream-changelog The warning should be fixed. That one is usually caused by the build system ignoring custom CFLAGS/CXXFLAGS/etc. The others would be nice to fix as well but are not essential. Otherwise, the package looks good - I'm not a DD though so I can't upload the package for you when it's done. Thanks, James
Attachment:
signature.asc
Description: This is a digitally signed message part