Bug#781763: RFS: node-coffeeify/1.0.0-1 [ITP]
On 04/03/2015 05:56 PM, Ross Gammon wrote:
> Thanks again for another review Bas.
>
> On 02/04/15 19:59, Sebastiaan Couwenberg wrote:
>> You may want to consider extending Use_through2.patch to cover all files
>> that use the through module, there are some tests that require it too.
>> Since the test dependencies cannot be satisfied in Debian strictly
>> required.
> I have fixed (I hope) all the other issues, but have one question before
> I finish. The package.json file also "requires" through. Should we leave
> this pristine so users know what upstream intended to be used (through),
> or also patch it to show what we used (through2)?
I think the package.json installed by the Debian package should reflect
the dependencies used by the package not npm.
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Reply to: