Bug#781763: [Pkg-javascript-devel] Bug#781763: RFS: node-coffeeify/1.0.0-1 [ITP]
Hi Ross,
Also thanks for your work on this package.
This package a few minor issues just like node-convert-source-map (#781701).
The Testsuite header in the control file should be XS-Testsuite.
The copyright year by npm2deb is not reflected in the upstream source,
it doesn't list any so I suggest to drop the year and keep the author.
The upstream sources contain several examples, you should consider
including them in the package.
You may want to consider extending Use_through2.patch to cover all files
that use the through module, there are some tests that require it too.
Since the test dependencies cannot be satisfied in Debian strictly required.
Patching the readme.markdown to replace node executable with nodejs as
it's called in Debian is also something you may want to consider. But
the commands in question also require some of the missing test
dependencies, so it's also not strictly required.
The project name in the upstream metadata uses the node- prefix, but
upstream doesn't. Dropping the prefix is better.
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Reply to: